- changed to tabbed display
- modified version detection
- adaption to new function version_compare() in ipkg.lua
- adaption to fixed Flag.parse() in cbi.lua
- add support new option "system.boot_delay"
- also fix#763
Signed-off-by: Christian Schoenebeck <christian.schoenebeck@gmail.com>
Closes#628 as suggestion was implemented and tested.
Added PID handling function (Fixes https://dev.openwrt.org/ticket/21506).
Signed-off-by: Vladimir Ulrich <admin@evl.su>
- fix handling of parameter "is_glue" and "dns_seerver"
- depends on https://github.com/openwrt/packages/pull/2875
Signed-off-by: Christian Schoenebeck <christian.schoenebeck@gmail.com>
Introduce option that enables the user to select max values
instead of averages for graphs if the user has disabled RRAsingle.
The option defaults to average values, which have been the default
in Luci statistics.
Remove 'optional' from RRASingle, as it is a key option for statistics.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
With rrdsingle the average values are used for graphing. As the
timescale increases (say over a day or month) the average values
progressively reduce. Using the maximum value over the longer periods
is arguably no less deceptive but it does produce more informative
graphs.
V2 - Invert the default path logic related to rra.single
Signed-off-by: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
transmission-daemon was split to -openssl and -polarssl variants,
so the old dependency needs to be removed.
luci-app-transmission will not install the transmission package
from now on. Instead the required transmission-daemon variant
needs to be installed separately.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
- fix problem not correctly handling "Bind Network" field #699
- some german translation extensions
Signed-off-by: Christian Schoenebeck <christian.schoenebeck@gmail.com>
Mark luci-app-radvd BROKEN as it has dependency to radvd,
which is still in oldpackages repo.
This commit fixes#553
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
- corrections because uclient-fetch now support "force ip version"
- remove translations already part of base.po/base.pot
Signed-off-by: Christian Schoenebeck <christian.schoenebeck@gmail.com>
Add an empty, normally invisible label after checkboxes and radio buttons
with cbi-input-{checkbox,radio} classes to allow CSS styling them as
suggested on http://www.paulund.co.uk/style-checkboxes-with-css
Signed-off-by: Nils Schneider <nils@nilsschneider.net>
Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
* Add support for disabling "force DNS queries to local resolver" option
* Remove deprecated logging options
Additionally remove unnecessary rmempty definitions.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
* Change "debug log" to "log"
* Add support for source descriptions
* Support new options for ping targets
* Simplify link to readme
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Simple user interface for the 'adblock' package from packages feed.
Adds 'Adblock' item to the Services menu in LuCI.
Allows enabling/disabling the service and selecting blocklists.
Configuration of the blocklist URLs and selection of Shalla categories
needs to be done manually to the config file, if needed.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
- support Radicale > v1.1
- modified version detection
- adaption to new function version_compare() in ipkg.lua
- adaption to fixed Flag.parse() in cbi.lua
- adaption to new property map.tabbed in cbi.lua using map template with extensions
- change optional values to non optional
- add support new option "system.boot_delay"
Signed-off-by: Christian Schoenebeck <christian.schoenebeck@gmail.com>
- fixes for https://dev.openwrt.org/ticket/21787
- changed detection of BusyBox nslookup compiled with musl, thanks to Arjen de Korte
Signed-off-by: Christian Schoenebeck <christian.schoenebeck@gmail.com>
Remove the usually empty standard deviation graph from the ping page.
The graph is empty for most users as collectd measures standard deviation
of individual pings inside the general interval of statistics collection.
Default setting for both ping interval and general collection interval
is 30s in Luci statistics, meaning just 1 ping per interval, which
leads to empty graph.
(To provide relveant data, the ping interval should be 1/4-1/5 of the
general collection interval. Even then the graph does not look very
informative due to different scaling than the latency graph.)
Note that this commit does not change collectd itself, which continues
to collect and calculate also the std.dev. data, which can be fetched
with 'rrdtool' if needed.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
- fixes for #611 and #620
- adaptions for ddns-scripts 2.6.0
-- add hint for problems with BusyBox nslookup compiled with musl and offer installing hostip package
-- add hint for not installed certificates inside /etc/ssl/certs and offer installing ca-certificates package https://github.com/openwrt/packages/pull/2243
-- check if malfunctional BusyBox nslookup installed, so disable using option dns_server if not Bind host or hostip installed
- optimizations
- cleanup: remove .po files without any translations
Signed-off-by: Christian Schoenebeck <christian.schoenebeck@gmail.com>
- remove unneeded assert() in tools/ddns.lua
- correct PKG_VERSION to the correct value from controller/ddns.lua
Signed-off-by: Christian Schoenebeck <christian.schoenebeck@gmail.com>
Some applications only support ipv4 so add ipv4only option
to host and hostport datatypes so that for thos applications
that when an IP address is specified only and ipv4 ip address
gets accepted.
Some applications only support ipv4 so add ipv4only option
to host and hostport datatypes so that for thos applications
that when an IP address is specified only and ipv4 ip address
gets accepted.
- support for new options "lookup_host", "param_enc" and "param_opt"
- rewritten ddns provider handling to only show/check needed options "domain", "username", etc.
- modified version check/handling incl. using new ipkg.compare_versions function
- modified map.title and map.description generation
- changed XHR.poll interval to 15 seconds on system status page
- using new value_parse function for testing and later implementation into cbi.lua
- some optimizations
Signed-off-by: Christian Schoenebeck <christian.schoenebeck@gmail.com>
Mark luci-app-voice-core and luci-app-voice-diag @BROKEN as their only functionality
is to create menu structure to be filled by items from luci-app-diag-devinfo,
which is currently broken due to missing dependencies.
References:
Initial commit creating all three packages:
820f11932f
Explanation why luci-app-diag-devinfo is currently broken:
ec6ccf1cd3
If luci-app-diag-devinfo gets its dependencies fixed, these two voice packages
might be re-activated. Combining the three packages would increase clarity.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Change the maximum length of a firewall zone name from 14 to 11 characters.
Longer names break iptables rule generation (max. 29 chars are allowed).
XT_EXTENSION_MAXNAMELEN = 29
29 - sizeof("postrouting_") - sizeof("_rule") - sizeof("\0") = 11
References to:
https://github.com/openwrt/luci/issues/507https://dev.openwrt.org/ticket/20380
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Mark luci-app-diag-devinfo @BROKEN as it has several failing dependencies:
Four dependencies from "oldpackages":
httping, mac-to-devinfo, smap-to-devinfo, netdiscover-to-devinfo
One dependency from "abandoned":
smap
(netdiscover is currently ok in trunk, but not in 15.05.)
Reference to Luci issue #523.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Ping statistics plugin allows the user to define multiple ping targets.
The graphs have so far shown multiple hosts in a stacked way.
Adjust graphs to show the target hosts separately (overlay=true).
Clarify the plugin definition with some additional line spacing.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Sync translations to the current strings.
Changes in luci-app-ddns, luci-app-mjpg-streamer, luci-app-qos,
luci-app-shadowsocks-libev, luci-app-statistics and luci-base
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Due to a lack of a test environment this support only covers thermal graphs
so far. Please send the output of "rrdtool info /tmp/rrd/*/sensors-*/*.rrd"
if your system happens to support voltage, power or fanspeed sensors.
Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>
If a plugin produces only one instance, e.g. netlink with just one interface
configured, then the controller will register no detail views which would
normally show all graphs but the index pacage of a given plugin will still
display the collapsed view without any possibility to reach the full listing.
Fix the problem by only rendering a linked index view when more than one
instance is present.
Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>
Reorganise the menu items of the Luci statistics module:
* Re-label "Collectd" to "Setup" and place it after the "Graphs" items.
- "Graphs" is used much more frequently so it should be first.
- Change "Collectd" menu item to "Setup" to clarify things.
* Re-label "System plugins" to "General plugins" to change sorting.
"Network / Output / System" changes to "General / Network / Output"
that is more logical order for the items.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
At some point since I last checked, the nut plugin for collectd changed the
names of the timeleft and percent datasets. Update the luci module to match
so that those graphs are generated correctly again.
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Switch the zonename validation to use
a compound datatype "and(uciname,maxlength(14))"
instead of a separate 'validate' function.
Remove the unnecessary function that was introduced by 34e875b
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Both init.d and uci-defaults scripts included in luci-app-statistics
still contained stuff related to lucid, which package was removed by
91b97bc9f6
Changes to scripts:
* init.d: lucid reference removed,
/var/etc creation moved earlier (before first possible use)
* uci-defaults: lucid parameters & restart removed
(but busybox httpd stuff was left intact, although it might be unnecessary)
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Mark luci-app-multiwan @BROKEN, as it depends on the old 'multiwan'
package, located in the deprecated 'oldpackages' feed.
'packages' feed contains both 'mwan3' and 'luci-app-mwan3' apps that
have superseded the old packages.
This should fix#395.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Adjust default settings to match the plugins installed by default
(default plugins: iwinfo, interface, load)
* disable plugins not installed by default to avoid error messages at start
* remove references to Freifunk interfaces, as most users do not have those
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
No functional changes, but the file is reorganised:
* group settings: general settings / output plugins / input plugins
* sort settings inside a group
* remove quotes from option names to match the current uci behaviour
* whitespace corrections
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Clarify the CPU time consumption graph by removing the "idle" data from it.
Especially with light traffic, removing "idle" enables the graph
to scale better and to properly show the CPU load variations.
If "idle" data needs to be seen, it might be added as a second graph below.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
* Clarify the short explanation on the statistics section's front page.
* Mention the possibility of additional collectd plugins to get more stats.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Utilise alt_autoscale_max to make the memory chart y-axis to scale better
for devices with e.g. 128 MB RAM.
Also fix the axis min value to 0.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Implement support for alternative scaling of the y-axis.
By default, rrdtool will autoscale to 1,2,5,10,20,50,100,200,... etc.,
which is not always suitable (e.g. memory charts for device with 128 MB).
Rrdtool 1.0.50 already supports alternative autoscaling that creates
a tighter y-axis. Implement graph-level options in Luci statistics to
support those boolean options as "alt_autoscale" and "alt_autoscale_max".
info at http://oss.oetiker.ch/rrdtool/doc/rrdgraph.en.html
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
CPU plugin in the Luci statistics was missing the label definitions,
so the field labels are like "cpu_system" instead of "System".
Add proper label definitions to CPU (like the other plugins already have).
The statistics graph was also missing softirq and interrupt stats, although colors
for them were defined. Softirq consumes massive amount of CPU especially with
any qos in use, so it is important for the user to see also that data. Add both
softirq and interrupt stats to the graph.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
This is useful in client mode as well, since it allows one to use --route-noexec and --up <cmd> or --route-up <cmd> to create routes manually instead of relying on whatever routes vpn server pushes down to the client.
mode=server dependency in luci was introduced together with script_security by mmunz back in 2011.with no explanation in the commit why mode=server was there.
Earlier update to collectd 5.4.1 changed the field from "ping" to "value",
which was changed in the graph definition here, but the label definition
was forgotten. Field's label now reads "ping_IPaddr_value".
Correct the label definition to show only IPaddr like the other two graphs.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Collectd 5.5.0 introduced new data to conntrack plugin:
In addition to the number of tracked connections there is also
the static max conntrack value and the calculated use percentage.
Luci's conntrack plugin intrepretes "conntrack-max" as a new data instance
and includes it in the graph in addition to the real "conntrack" number.
Eliminate "max" from graph by specifying empty "" instance as data source.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
The regex used to process the iface query string argument in
vnstat.htm was stripping underscores, which caused the graph not to
display for interfaces with names containing underscores. This
patch adds the underscore to that regex so that the interface name
will be correct and the graph will be displayed.
Signed-off-by: Michael Marley <michael@michaelmarley.com>
Stop sys upgrade automatically disabling miniupnpd on first boot after upgrade.
I spent a lot of time tracking this behaviour down which only occurs if you have luci-app-upnp installed.
Cleanup luci-app-qos, as it still contains references to l7 functionality
that has been removed both from kernel and from qos-scripts.
Qos config page has a non-functional "Service" option and every visit to
qos config page generates currently an error as no l7 files can be found.
daemon.err uhttpd[2285]: find: /etc/l7-protocols/: No such file or directory
Patch removes "Service" option and the l7 file search.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
fixed version checking in function ipkg_ver_compare()
Reported issue #387 and openwrt/packages issue 1285
Signed-off-by: Christian Schoenebeck <christian.schoenebeck@gmail.com>
* reflect updated language file for zh-cn
* change default for retry_count to 0 compatible to ddns-scripts 2.4.2-1
* addition to retry_count help description
* modified dependency on ddns-scripts 2.4.2-1
Signed-off-by: Christian Schoenebeck <christian.schoenebeck@gmail.com>
New Application
!!! Dependency not set because there are two packages "radicale-py2" and
"radicale-py3" (currently BROKEN) available !!!
Signed-off-by: Christian Schoenebeck <christian.schoenebeck@gmail.com>
Fix log spam that uhttpd logging change has brought to surface.
Sun Mar 1 11:10:42 2015 daemon.err uhttpd[2293]: /usr/lib/lua/luci/dispatcher.lua:433: Failed to execute call dispatcher target for entry '/admin/statistics/graph/conntrack'.
Sun Mar 1 11:10:42 2015 daemon.err uhttpd[2293]: The called action terminated with an exception:
Sun Mar 1 11:10:42 2015 daemon.err uhttpd[2293]: .../luci/controller/luci_statistics/luci_statistics.lua:153: attempt to use a closed file
Closing the png file explicitly on line 153 is unnecessary, as
ltn12's source.file method already closes the file after use.
https://github.com/openwrt/luci/blob/master/modules/luci-base/luasrc/ltn12.lua#L119
More info at https://dev.openwrt.org/ticket/19083#comment:2
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
* remove extra apperror.lua page
* so no nore need for extra directory inside model/cbi
* add option temporary_directory needed for external filters
* remove special handling of bootstrap theme #298#334
* modified version handling suggested in #335
Signed-off-by: Christian Schoenebeck <christian.schoenebeck@gmail.com>
* remove usage of opkg via system call for version handling
thanks to Jo-Philipp Wich #335
* remove special handling of bootstrap theme #298#334
Signed-off-by: Christian Schoenebeck <christian.schoenebeck@gmail.com>
Current OpenWrt trunk now relays uhttpd stderr to syslog, so don't spam
it with "iptables: No chain/target/match by that name." when miniupnpd
is not configured but its status is queried by an overview page applet.
Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>
- implement new option bind_interface
- fixes problems when updating status displays (i.e. showing Software update needed)
- new links to OpenWrt wiki
- new screen to set global settings
- implements global option use_curl
Signed-off-by: Christian Schoenebeck <christian.schoenebeck@gmail.com>
* move from openwrt/packages to openwrt/luci
* adaption to new LuCI subdirectory structure
* fix error handling
* modified version handling
* fixed translations
Signed-off-by: Christian Schoenebeck <christian.schoenebeck@gmail.com>
- adaption Makefile to changed luci.mk
- description in Makefile for correct version handling
- modified handling to detect and display installed version
- new functions ipkg_ver_installed() and ipkg_ver_compare
- correct wrong spellings
- modified language template and German translation
Signed-off-by: Christian Schoenebeck <christian.schoenebeck@gmail.com>
