: is used to delimit fields in DEF: rrd instructions, so when it appears
in a filename it must be escaped using \.[1] This commit adds the
escaping.
I discovered the issue after configuring collectd-mod-ping to monitor an
IPv6 host (2001:19f0:5:727:5b56:205d:ff55:2208). Accessing
https://192.168.0.1/cgi-bin/luci/admin/statistics/graph/ping would cause
the following messages to be logged:
Wed Nov 14 23:04:33 2018 daemon.err uhttpd[30261]: ERROR: can't parse DEF '2ping_avg_raw=/tmp/rrd/openwrthost/ping/ping-2001:19f0:5:727:5b56:205d:ff55:2208.rrd:value:AVERAGE' -2
Wed Nov 14 23:04:33 2018 daemon.err uhttpd[30261]: ERROR: can't parse DEF '2ping_droprate_avg_raw=/tmp/rrd/openwrthost/ping/ping_droprate-2001:19f0:5:727:5b56:205d:ff55:2208.rrd:value:AVERAGE' -2
and the graphs would not display. After applying this commit, the
graphs display correctly and no messages are logged.
1. https://oss.oetiker.ch/rrdtool/doc/rrdgraph_data.en.html#IDEF
Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
Move the old luci.model.ipkg utility class into a separate package and
let the components using it depend on the new library package.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Add a new luci-app-opkg which is a feature-complete replacement for the
builtin opkg functionality of luci-mod-system using mostly client side
JavaScript to reduce the amount of server side processing.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Use the standard addEventListener() instead. Also remove an old
cbi_validate_field() call referencing a not existing field.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Make list option rt_table_lookup configurable in luci.
With this option we could define additional routing tables which get
scanned by mwan3 and then get added to the connected ipset.
The entries will be treated as connected network and will not get
mangeld by mwan3.
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Add the configuration option rtmon to luci.
With this parameter we could adjust how often the routing table get
synced between main routing table and the interface routing table.
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Remove old rrdtool.po* files that have been deprecated already
in 2011-2015.
Also remove reference to them from i18n-sync.pl
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Thanks to a recent commit, the translation files will now
have info about locations where the string is used. That
can help is deciding the correct translation, as all contexts
are more easily found.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
* add the ability to upload ovpn files directly,
incl. appropriate uci entry in openvpn config
* add the ability to edit ovpn files directly ('file' mode),
beside the 'basic' and 'advanced' modes for normal setups
* client side checks to validate instance name & template selection,
incl. online error reporting
* automatically remove non-ascii characters & windows line endings
from transfered ovpn file
* change from after_commit to after_apply hook
* remove misleading default values for Port & Protocol in Overview
Signed-off-by: Dirk Brenken <dev@brenken.org>
The "Services" menu option of olsr on the top of the web interface
is not there.
A specific version of the App name was in the controller service
Removing the limitation will fix the problem
https://github.com/freifunk-berlin/firmware/issues/594
Signed-off-by: mmouselli <m.mouselli@syseleven.de>
Add collectd-mod-curl plugin support. Which can do some complex track,
such as grab stock, but by now, only response time are supported.
Signed-off-by: Chizhong Jin <pjincz@gmail.com>
Option `aggressive` is supported by dump1090 binary, but oddly missing in
dump1090.init. Nevertheless, neither of them support the wrong
`agressive`.
Signed-off-by: David Yang <mmyangfl@gmail.com>
This has worked before because the interface variable is global. But
this is not nice. So this commit will fix this.
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Since commit f6bfac211 ("luci-mod-status: rework iptables status page"),
nothing in luci-base depends on the iptparser class anymore, so fold it
out into a separate package and let the few apps that require it depend
on the new library package.
Saves about 10K uncompressed in luci-base while the iptables status
rework enlarged the markup by roughly 5KB, saving roughly 5KB of size
overall.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
AgentX support doesn't actually require TCP, it also works over unix
domain sockets, and UDS is the only method that's compiled in by
default. Remove that misleading text, and make the section
add/removable so that you can remove it to disable agentx support.
Behaviour with multiple sections is undefined. (don't do that!)
This matches the current behaviour of the snmpd init script, which will
enable agentx with the compile time default settings if the agentx
socket config is blank/missing.
Signed-off-by: Karl Palsson <karlp@etactica.com>
* with the config option 'trm_radio' you can now restrict travelmate
to a single radio (e.g. 'radio1') or change the overall
scanning order (e.g. 'radio1 radio2 radio0')
* LuCI: show QR codes now inline on the overview page
(collapsed by default)
Signed-off-by: Dirk Brenken <dev@brenken.org>
Do not concatenate the yet undefined mtime variable to avoid a controller
error with backtrace.
Fixes: b3642f476 ("luci-app-nlbwmon: add proper file names for json and csv exports.")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
* add optional QR Code support to status page (per wg Interface),
submitted information via QR code are:
- [Interface] (list of) Address / PrivateKey
- [Peer] Endpoint / PublicKey / (list of) AllowedIPs
- support multiple interfaces and peers
* fix XHTML rendering errors with OpenWrt standard theme
* fix logical glitch with empty descriptions, remove needless variables
* left align the output for better viewing esp. with material theme
* freshen up design a little bit
* switch space indentation to tabs
Signed-off-by: Dirk Brenken <dev@brenken.org>
Currently, the json and csv exports are just named `data` which is not
intuitive. This adds proper file name extensions using the
Content-disposition HTTP header.
Suggested-by: Ameer Dawood <ameer1234567890@gmail.com>
[slightly reword commit message, squash commits]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Add description fields to luci-app-wireguard similar to those in
luci-proto-wireguard.
Ref: https://github.com/openwrt/luci/commit/140f41b4
Suggested-by: "rwalli" <rwalli@gmx.net>
[squash commits, reword commit message, remove semicolons,
remove trailing white space]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Imported from https://github.com/remakeelectric/owrt_pub_feeds/tree/master/luci-app-snmpd
Only provides configuration of basic authentication and system level
options, not even close to the entire slew of options that net-snmp
supports, but the basics are still helpful, and a base for future work.
Signed-off-by: Karl Palsson <karlp@etactica.com>
* remove obsolete config options according to
openwrt/openwrt@89b8ba9, fix for #2135
* whitespace/intendation fixes
* replace fieldset leftover with div
* fix finally recipe options transfer to regular config with "Add"
Signed-off-by: Dirk Brenken <dev@brenken.org>