Difuse/luci
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
luci/applications
History
Kevin Locke 1bbc419e7a luci-app-statistics: quote : in filenames for DEF 
: is used to delimit fields in DEF: rrd instructions, so when it appears
in a filename it must be escaped using \.[1]  This commit adds the
escaping.

I discovered the issue after configuring collectd-mod-ping to monitor an
IPv6 host (2001:19f0:5:727:5b56:205d:ff55:2208).  Accessing
https://192.168.0.1/cgi-bin/luci/admin/statistics/graph/ping would cause
the following messages to be logged:

    Wed Nov 14 23:04:33 2018 daemon.err uhttpd[30261]: ERROR: can't parse DEF '2ping_avg_raw=/tmp/rrd/openwrthost/ping/ping-2001:19f0:5:727:5b56:205d:ff55:2208.rrd:value:AVERAGE' -2
    Wed Nov 14 23:04:33 2018 daemon.err uhttpd[30261]: ERROR: can't parse DEF '2ping_droprate_avg_raw=/tmp/rrd/openwrthost/ping/ping_droprate-2001:19f0:5:727:5b56:205d:ff55:2208.rrd:value:AVERAGE' -2

and the graphs would not display.  After applying this commit, the
graphs display correctly and no messages are logged.

1.  https://oss.oetiker.ch/rrdtool/doc/rrdgraph_data.en.html#IDEF

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
2018-11-14 16:55:24 -07:00
..
luci-app-adblock luci-app-adblock: consolidate css 2018-11-14 10:45:18 +01:00
luci-app-advanced-reboot i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-ahcp i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-aria2 luci-lib-ipkg: move out of luci-base 2018-11-14 20:46:04 +01:00
luci-app-attendedsysupgrade Add missing variable declarations in JavaScript code 2018-10-28 22:38:20 +01:00
luci-app-banip luci-app-banip: fix remaining css issues 2018-11-14 11:44:48 +01:00
luci-app-bcp38 i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-clamav i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-commands i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-coovachilli i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-cshark treewide: always include cbi.js 2018-07-09 11:51:43 +02:00
luci-app-ddns luci-lib-ipkg: move out of luci-base 2018-11-14 20:46:04 +01:00
luci-app-diag-core i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-dnscrypt-proxy i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-dump1090 luci-app-dump1090: Fix typo of a dumb option 2018-10-12 23:28:18 +08:00
luci-app-dynapoint luci-lib-ipkg: move out of luci-base 2018-11-14 20:46:04 +01:00
luci-app-e2guardian luci-app-e2guardian: add e2guardian application 2017-02-15 14:40:48 +01:00
luci-app-firewall luci-app-firewall: remove references to cbi_bind() 2018-11-14 20:46:04 +01:00
luci-app-freifunk-diagnostics treewide: always include cbi.js 2018-07-09 11:51:43 +02:00
luci-app-freifunk-policyrouting i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-freifunk-widgets Globally replace luci.dispatcher.build_url(...) with url(...) invocations 2015-10-07 19:07:36 +02:00
luci-app-fwknopd i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-hd-idle i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-https_dns_proxy i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-ltqtapi treewide: convert HTML tables to div 2018-05-28 15:18:45 +02:00
luci-app-lxc treewide: always include cbi.js 2018-07-09 11:51:43 +02:00
luci-app-meshwizard i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-minidlna i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-mjpg-streamer i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-mosquitto luci-app-mosquitto: validate paths as path, not file 2018-09-24 16:02:24 +00:00
luci-app-mwan3 luci-app-mwan3: remove deprecated local_source option 2018-11-14 09:22:20 +01:00
luci-app-nft-qos i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-nlbwmon i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-noddos i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-ntpc i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-nut luci-app-nut: Add support for NUT configuration 2018-08-29 01:03:17 -04:00
luci-app-ocserv luci-app-ocserv: remove unneeded br element from template 2018-07-20 09:10:45 +02:00
luci-app-olsr Merge pull request #2259 from pmelange/luci-app-olsr-new-json-lib 2018-11-14 20:50:03 +01:00
luci-app-olsr-services get rid of library version numbers in luci olsrd code 2018-10-25 21:56:06 +02:00
luci-app-olsr-viz Add missing variable declarations in JavaScript code 2018-10-28 22:38:20 +01:00
luci-app-openvpn i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-opkg applications: add luci-app-opkg 2018-11-14 20:46:04 +01:00
luci-app-p910nd i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-pagekitec i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-polipo i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-privoxy luci-lib-ipkg: move out of luci-base 2018-11-14 20:46:04 +01:00
luci-app-qos i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-radicale luci-lib-ipkg: move out of luci-base 2018-11-14 20:46:04 +01:00
luci-app-rp-pppoe-server luci-app-rp-pppoe: Fix typo 2018-06-23 17:14:23 +01:00
luci-app-samba i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-samba4 i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-shadowsocks-libev i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-shairplay i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-siitwizard get rid of library version numbers in luci olsrd code 2018-10-25 21:56:06 +02:00
luci-app-simple-adblock i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-snmpd luci-app-snmpd: Allow turning off agentx 2018-10-08 11:27:53 +00:00
luci-app-splash i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-squid luci-app-squid: added squid application 2017-02-15 14:41:24 +01:00
luci-app-statistics luci-app-statistics: quote : in filenames for DEF 2018-11-14 16:55:24 -07:00
luci-app-tinyproxy i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-transmission luci-lib-ipkg: move out of luci-base 2018-11-14 20:46:04 +01:00
luci-app-travelmate Merge pull request #2284 from dibdot/travelmate 2018-11-14 11:49:05 +01:00
luci-app-udpxy Use numeric prefixes for uci-defaults scripts 2016-01-27 16:50:19 +01:00
luci-app-uhttpd i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-unbound i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-upnp i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-vnstat i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-vpnbypass i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-watchcat i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-wifischedule i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00
luci-app-wireguard luci-*-wireguard: Remove inactive maintainer 2018-11-10 13:54:59 +01:00
luci-app-wol i18n: sync translations, add location annotatations 2018-11-07 18:10:59 +02:00