This calls striptags() on the hostname to prevent any XSS over the
hostname. This should fix CVE-2021-33425 as far as I understood it.
If someone adds some Javascript into system.@system[0].hostname it would
have been directly added to the page, this prevents the problem.
This can only be exploited by someone being able to modify the uci
configuration, normally a user with such privileges could also just
modify the webpage.
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Using the scalable graphic in place of the static png file saves some
ressources in flash and network. It also aligns the filetype to the type
announced to the browser.
fixes GitHub-issue #5051
Signed-off-by: Sven Roederer <freifunk@it-solutions.geroedel.de>
Before fixed, if we have two nodes: 'services/ddns' and 'services/ddnsto',
click any one of they, will show they all actived.
Signed-off-by: Liangbin Lian <jjm2473@gmail.com>
Legacy Lua views might declare a global `css` variable to inject custom
styles into the template header. Support this mechanism in the OpenWrt 2020
theme as well.
Ref: https://github.com/openwrt/luci/issues/4972
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
It's been unmaintained for ages and became useless.
Better just limit regular luci-mod-admin to only show basic
functionality in case `ubus call system board` indicates we are running
off initramfs.
Singed-off-by: Daniel Golle <daniel@makrotopia.org>
Fix table rendering in the small responsive breakpoint on Safari (which
ignores `display: block;` for `<td>` elements).
Signed-off-by: Bryan Forbes <bryan@reigndropsfall.net>
The Rosy theme has been marked broken for over a year,
since 23 Dec 2019. Remove it now, so that it does not
get into the next release branch 20.xx (or 21.xx).
Reference to
https://github.com/openwrt/luci/issues/3759#issuecomment-599436159
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
After moving section title from `legend`, which was translated to `span`
with style `panel-title`, to `h3`, update also CSS style to match first
`h3` in `cbi-section`.
Signed-off-by: Oldřich Jedlička <oldium.pro@gmail.com>
Remove the reference to setting a password being linked to SSH capability.
(SSH has been initially enabled since year 2015.)
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
In the Material theme, clicking on the logo takes you to the status page.
This seems logical, and is very helpful. But in OpenWrt 2020, clicking on
the hostname doesn't do anything, so just pulling the same href from Material
so the link works in this theme as well.
Signed-off-by: Russell Morris <rmorris@rkmorris.us>
[adjust subject, commit message]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
In the Material theme, clicking on the logo takes you to the status page.
This seems logical, and is very helpful. But in Bootstrap, it doesn't
do anything, so just pulling the same href from Material to Bootstrap,
so the link works in Bootstrap as well.
Signed-off-by: Russell Morris <rmorris@rkmorris.us>
[adjust commit subject, squash commits]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
If we build multi-themes into firmware, each of them set itself
to be the default theme, what theme should it be?
To make it clear, we only set mediaurlbase if the theme is the
first time to be installed/built-in.
This resolve the issue that theme always change to somewhat default
after upgrading the firmware even with a config-keep-upgrade
Signed-off-by: Chen Minqiang <ptpt52@gmail.com>
Since the trailing comma rule is combined with other selectors by CSSmin,
the resulting minified stylesheet has some unexpected margin quirks.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
The cssmin utility incorrectly breaks up calc() expressions when
minifying rules. Avoid the problem by trimming uneeded spaces.
Fixes: #3801
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
- Properly format mode menu
- Fadeout of truncated cell labels in mobile layout
- Limit maximum width of modal overlays
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
- Style input fields without type to treat them like text inputs
- Style modal overlay as flex column to fix float clearing with adblock 4
- Add margin to standalone textareas
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
The `data-type` attribute is used to bind datatype validators to a widget
while some templates used the same attribute to denote the name of the
underlying widget.
Change the `data-type` attributes referring to the widget name to
`data-widget` in order to stop the JS token error spam.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
- Don't remove background for disabled buttons
- Move inactive tooltip element further out of the view area
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Depending on the browser, it is sometimes difficult to scroll if moused
over or after clicking or highlighting text. I often have to click outside
the text to be able to scroll again. The browser perceives that there is
scrolling space/content within the <textarea> element because it is
almost, but not exactly, the same size as its parent <div> element,
when in reality, there is no more text content. This causes scrolling
within the element with a range of just a few pixels, and the rest of
the page remains static.
This is easily solved by adding the "overflow-y" property with value
"hidden". Tested by myself on Chrome 64-bit Windows 10
Signed-off-by: Michael Pratt <mpratt51@gmail.com>
[rewrap commit message, fix Sob syntax]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Add some CSS band aids to fix styling and positioning of hidden tab panes,
cbi maps in modal dialogs and nested cbi sections.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
- Apply the same style to <button> and <input type="button"> elements
- Increase width of modal CBI dialogs
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Fixed a overview page style issue with interface boxes for
bootstrap, material and rosy themes.
The issue only appears in the Chrome browser and lies in the
fact that the block with the device name and MAC address gets
out of the interface block.
Signed-off-by: Anton Kikin <a.kikin@tano-systems.com>
* Remove excess font dependency
* Retain two glyphs as svg
* Store svg icons externally
* Add logout icon
* Replace spaces with tabs in script
* Various minor fixes
Signed-off-by: Shun Jou <shunjou@gmail.com>
After opening an external hyperlink in a new browser tab, LuCI hangs in the
load screen. This commit will fix this issue.
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Even Freifunk was one of the major factory to create the LuCI-system, it's
now only a very small part of LuCI. LuCI has become a much bigger thing
and it seems that it's time to move the packages only relating to Freifunk
into it's own feed.
On the mailinglist it was discussed [1] and a repo below the general
Freifunk team on github was created.
This commit removes all packages that will be hosted in the new repo [2]
1 - http://lists.freifunk.net/pipermail/wlannews-freifunk.net/2019-February/004818.html
2 - https://github.com/freifunk/openwrt-packages
Signed-off-by: Sven Roederer <freifunk@it-solutions.geroedel.de>
If you change the color of the submenues then the colors of the toplevel
should also be changed into the same color.
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
- Collapse table borders by default
- Vertically align table cell content
- Inherit font family and size for form widgets
- Fix redundant horizontal padding for cell labels
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
* Restore theme to near original style
* Properly declare variable fallbacks
* More consistent table and border styling
* Improve responsive design scaling
* Add static ripple effect to sidebar menu
* Style command output as terminal
* Comb coding style and widespread cleanup
* Various other improvements and fixes
Signed-off-by: Shun Jou <shunjou@gmail.com>
Very long values without whitespace can easily overflow the dynlist item
container, so allow the browser to forcibly break such lines.
Reported-by: Hannu Nyman <hannu.nyman@iki.fi>
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Allow the tab menu line to wrap around on narrow screens to fix the issue
reported in PR #2333.
Also add the .nowrap utility class to the Bootstrap theme while we're
touching it.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Add responsive CSS to improve the rendering on small screen devices.
Tested on Mobile Safari using an iPhone 5 and iPhone 6, ymmv for other
platforms.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Add the missing error css class definitions.
Highlights the wrong inputs detected by the cbi validation function.
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Drop rules specific to the old status page progress bars and rework the
cbi element rules to work independently of a parent form tag.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
