Material is a "flex" theme. Better to use "gap" in place of "margin" to
add some space between elements inside "flex" elements.
This fixes the problem specially when there are text elements inside the
"flex" and don't hurt when there are images.
Signed-off-by: Miguel Angel Mulero Martinez <migmul@gmail.com>
The latest fix to fix the logout worked, but it was not applied to all
the resolutions, and I have observed the same problem exists for the
dasboard optional component.
Looking at the code, it seems only the components without submenu, have the
data-title element, so this fix modifies the style for all of them, not
relying on the position or text content.
Signed-off-by: Miguel Angel Mulero Martinez <migmul@gmail.com>
The text inside the buttons is aligned to the top. This change mades
it aligned to the center.
Signed-off-by: Miguel Angel Mulero Martinez <migmul@gmail.com>
The control-group div does not flex. The buttons overflow the screen.
This change mades them flex.
Signed-off-by: Miguel Angel Mulero Martinez <migmul@gmail.com>
The CSS applies a different padding for td elements with 33% width. This
misaligns the text from this td to the others td.
This change modifies the CSS to apply the same padding to all of the
sibling td.
Signed-off-by: Miguel Angel Mulero Martinez <migmul@gmail.com>
The data-title attribute style depends on the content in the css rule.
When translated to other language, the css rule fails.
This change uses the position and not the content to apply the style.
Signed-off-by: Miguel Angel Mulero Martinez <migmul@gmail.com>
This reverts commit 3758ab9479.
The solution is not good. It breaks in some way the English UI to fix
localizated UI.
It will be fixed again in other commit.
Signed-off-by: Miguel Angel Mulero Martinez <migmul@gmail.com>
The icon of the logout option overflows the text. This reduces the size of the icon to not overflow.
Signed-off-by: Miguel Angel Mulero <mcgivergim@gmail.com>
The text of the progressbar is bigger than the progressbar height. This removes the font-size element that produced that.
Signed-off-by: Miguel Angel Mulero <mcgivergim@gmail.com>
Use an traditional HTML form with post submit action to the same URL in
order to simplify the login process and not rely on the discarded login
XHR reply properly setting the login cookie.
This will also avoid one useless request on login and hopefully fix login
issues reported with various browser environments.
As a bonus, the resulting code is somewhat smaller as well.
Ref: https://forum.openwrt.org/t/login-does-not-work/113360
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
The GalanoGrotesque font used by the openwrt2020 theme does not support non-
latin symbols.
If latin and non-latin symbols are used together in one line it looks strange
because for latin symbols GalanoGrotesque is used but for non-latin symbols a
fallback font is used (sans-serif).
This patch changes default font to Helvetica for the "bg", "ru", "uk", "el"
and "he" locales.
Original patch was written by Jo-Philipp Wich
Fixes: #5580
Signed-off-by: Sergey V. Lobanov <sergey@lobanov.in>
[reword commit message, drop "de" from exception list]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
- Add proper top and bottom margin for tab descriptions
- Allow flex wrapping for cbi-value rows
- Ensure that nested table/grid sections always take the full width
- Make table/grid section row action buttons are as narrow as possible
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Since the removal of the clearfix styles, overlong captions will displace
subsequent input field rows.
Fix the issue by replace floating label + field margin with flexbox styles.
Fixes: #5535
Fixes: 8055acc9be ("luci-theme-bootstrap: overhaul styles")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
- Use the proper dialog class name to apply changelog styles
- Darken grey background and borders
Fixes: 5bd111f58f ("luci-theme-bootstrap: fix uci changelog and readonly input styles")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Revert to the previous uci-defaults behaviour of only setting the
selected theme to Bootstrap if the Bootstrap entry didn't exist yet
in the configuration.
Ref: https://forum.openwrt.org/t/luci-theme-behaviour-change/112047
Fixes: ed86f03a9f ("luci-theme-bootstrap: add explicit dark/light mode selection")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Register two further "virtual" themes called BootstrapDark and
BootstrapLight which force dark and light mode respectively.
The actual Bootstrap theme itself will continue to auto-select
dark mode preference based on OS/Browser preference settings.
Fixes: #5492
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Fixed overlay display failures for users on mobile, or users who booted
up in safe mode XD. Noticeable when vertical or horizontal real-estate
is too small for the displayed overlay.
This failure is most evident when you "edit" an interface, or display
your unsaved changes.
When content is wider than the screen view, the table hugs the (widest)
content maximally, and the overlay window becomes scrollable.
Disabled -webkit-overflow-scrolling, left, and right, because both FF
and Safari disable them as invalid anyway.
Signed-off-by: Paul Dee <systemcrash@users.noreply.github.com>
[Merge duplicate modal declarations, remove not applicable modal
flexbox properties]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
- introduce new variable --text-color-highest which results in #000/#fff
for bright and dark modes respectively
- drop unused navigation style rules and selectors
- use sticky positioning for header bar and drop top margin hacks
- use flex box layout for header bar contents
- use uniform line-height for button elements instead of pixel paddings
- fix too bright .cbi-value bottom border in mobile dark mode
- avoid rendering duplicate .cbi-value bottom borders for nested sections
- simplify header markup, get rid of unused container elements
- use non-wrapping flex box layout for page actions, prioritize primary
action button in automatic width calculation
- fix border radius of ifacebox headers
- use brightest color for log output textareas
- fix dark mode colors for mode menu
- use flex layout for footer
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Some devices offer a full LuCI interface from their recovery interface.
As it's read-only it should only be used for installing sysupgrades and
therefore warn users that no settings are saved.
Signed-off-by: Paul Spooren <mail@aparcar.org>
Remove line-height css for syslog textarea as it cause some
problem with displaying all the rows of the syslog.
(Row line are calculated with a line-height of 1)
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
- Drop jquery lib
- Move to the new menu.js implementation
- Rework css to mimic old js transition
- Rework footer and header to new implementation
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
This calls striptags() on the hostname to prevent any XSS over the
hostname. This should fix CVE-2021-33425 as far as I understood it.
If someone adds some Javascript into system.@system[0].hostname it would
have been directly added to the page, this prevents the problem.
This can only be exploited by someone being able to modify the uci
configuration, normally a user with such privileges could also just
modify the webpage.
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Using the scalable graphic in place of the static png file saves some
ressources in flash and network. It also aligns the filetype to the type
announced to the browser.
fixes GitHub-issue #5051
Signed-off-by: Sven Roederer <freifunk@it-solutions.geroedel.de>
Before fixed, if we have two nodes: 'services/ddns' and 'services/ddnsto',
click any one of they, will show they all actived.
Signed-off-by: Liangbin Lian <jjm2473@gmail.com>
Legacy Lua views might declare a global `css` variable to inject custom
styles into the template header. Support this mechanism in the OpenWrt 2020
theme as well.
Ref: https://github.com/openwrt/luci/issues/4972
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
It's been unmaintained for ages and became useless.
Better just limit regular luci-mod-admin to only show basic
functionality in case `ubus call system board` indicates we are running
off initramfs.
Singed-off-by: Daniel Golle <daniel@makrotopia.org>
Fix table rendering in the small responsive breakpoint on Safari (which
ignores `display: block;` for `<td>` elements).
Signed-off-by: Bryan Forbes <bryan@reigndropsfall.net>
The Rosy theme has been marked broken for over a year,
since 23 Dec 2019. Remove it now, so that it does not
get into the next release branch 20.xx (or 21.xx).
Reference to
https://github.com/openwrt/luci/issues/3759#issuecomment-599436159
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
After moving section title from `legend`, which was translated to `span`
with style `panel-title`, to `h3`, update also CSS style to match first
`h3` in `cbi-section`.
Signed-off-by: Oldřich Jedlička <oldium.pro@gmail.com>
Remove the reference to setting a password being linked to SSH capability.
(SSH has been initially enabled since year 2015.)
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
In the Material theme, clicking on the logo takes you to the status page.
This seems logical, and is very helpful. But in OpenWrt 2020, clicking on
the hostname doesn't do anything, so just pulling the same href from Material
so the link works in this theme as well.
Signed-off-by: Russell Morris <rmorris@rkmorris.us>
[adjust subject, commit message]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
In the Material theme, clicking on the logo takes you to the status page.
This seems logical, and is very helpful. But in Bootstrap, it doesn't
do anything, so just pulling the same href from Material to Bootstrap,
so the link works in Bootstrap as well.
Signed-off-by: Russell Morris <rmorris@rkmorris.us>
[adjust commit subject, squash commits]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
If we build multi-themes into firmware, each of them set itself
to be the default theme, what theme should it be?
To make it clear, we only set mediaurlbase if the theme is the
first time to be installed/built-in.
This resolve the issue that theme always change to somewhat default
after upgrading the firmware even with a config-keep-upgrade
Signed-off-by: Chen Minqiang <ptpt52@gmail.com>
Since the trailing comma rule is combined with other selectors by CSSmin,
the resulting minified stylesheet has some unexpected margin quirks.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
The cssmin utility incorrectly breaks up calc() expressions when
minifying rules. Avoid the problem by trimming uneeded spaces.
Fixes: #3801
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
- Properly format mode menu
- Fadeout of truncated cell labels in mobile layout
- Limit maximum width of modal overlays
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
- Style input fields without type to treat them like text inputs
- Style modal overlay as flex column to fix float clearing with adblock 4
- Add margin to standalone textareas
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
