Difuse/difuse-phone-android
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Hide echo tester setting if debug mode isn't enabled as it can mislead users over what it can be used for

Browse source
This commit is contained in:
Sylvain Berfini 2023-01-30 14:04:11 +01:00
parent b463025a0e
commit 0e3c82b519
2 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/src/main/java/org/linphone/activities/main/settings/viewmodels/AudioSettingsViewModel.kt
View file

@ -78,6 +78,7 @@ class AudioSettingsViewModel : GenericSettingsViewModel() {
} }
private var echoTesterIsRunning = false private var echoTesterIsRunning = false
val echoTesterStatus = MutableLiveData<String>() val echoTesterStatus = MutableLiveData<String>()
val showEchoTester = MutableLiveData<Boolean>()
val adaptiveRateControlListener = object : SettingListenerStub() { val adaptiveRateControlListener = object : SettingListenerStub() {
override fun onBoolValueChanged(newValue: Boolean) { override fun onBoolValueChanged(newValue: Boolean) {
@ -161,6 +162,8 @@ class AudioSettingsViewModel : GenericSettingsViewModel() {
prefs.getString(R.string.audio_settings_echo_canceller_calibration_summary) prefs.getString(R.string.audio_settings_echo_canceller_calibration_summary)
} }
echoTesterStatus.value = prefs.getString(R.string.audio_settings_echo_tester_summary) echoTesterStatus.value = prefs.getString(R.string.audio_settings_echo_tester_summary)
showEchoTester.value = prefs.debugLogs // Don't show echo tester unless debug mode is enabled, may confuse user over what it should be used for
preferBluetoothDevices.value = prefs.routeAudioToBluetoothIfAvailable preferBluetoothDevices.value = prefs.routeAudioToBluetoothIfAvailable
initInputAudioDevicesList() initInputAudioDevicesList()
initOutputAudioDevicesList() initOutputAudioDevicesList()

1
app/src/main/res/layout/settings_audio_fragment.xml
View file

@ -80,6 +80,7 @@
<include <include
layout="@layout/settings_widget_basic" layout="@layout/settings_widget_basic"
android:visibility="@{viewModel.showEchoTester ? View.VISIBLE : View.GONE, default=gone}"
linphone:title="@{@string/audio_settings_echo_tester_title}" linphone:title="@{@string/audio_settings_echo_tester_title}"
linphone:subtitle="@{viewModel.echoTesterStatus}" linphone:subtitle="@{viewModel.echoTesterStatus}"
linphone:listener="@{viewModel.echoTesterListener}"/> linphone:listener="@{viewModel.echoTesterListener}"/>