From 0e3c82b51933ac9171a417fef479fc022658de60 Mon Sep 17 00:00:00 2001
From: Sylvain Berfini <sylvain.berfini@belledonne-communications.com>
Date: Mon, 30 Jan 2023 14:04:11 +0100
Subject: [PATCH] Hide echo tester setting if debug mode isn't enabled as it
 can mislead users over what it can be used for

---
 .../main/settings/viewmodels/AudioSettingsViewModel.kt         | 3 +++
 app/src/main/res/layout/settings_audio_fragment.xml            | 1 +
 2 files changed, 4 insertions(+)

diff --git a/app/src/main/java/org/linphone/activities/main/settings/viewmodels/AudioSettingsViewModel.kt b/app/src/main/java/org/linphone/activities/main/settings/viewmodels/AudioSettingsViewModel.kt
index bc269e819..c8d363d0c 100644
--- a/app/src/main/java/org/linphone/activities/main/settings/viewmodels/AudioSettingsViewModel.kt
+++ b/app/src/main/java/org/linphone/activities/main/settings/viewmodels/AudioSettingsViewModel.kt
@@ -78,6 +78,7 @@ class AudioSettingsViewModel : GenericSettingsViewModel() {
     }
     private var echoTesterIsRunning = false
     val echoTesterStatus = MutableLiveData<String>()
+    val showEchoTester = MutableLiveData<Boolean>()
 
     val adaptiveRateControlListener = object : SettingListenerStub() {
         override fun onBoolValueChanged(newValue: Boolean) {
@@ -161,6 +162,8 @@ class AudioSettingsViewModel : GenericSettingsViewModel() {
             prefs.getString(R.string.audio_settings_echo_canceller_calibration_summary)
         }
         echoTesterStatus.value = prefs.getString(R.string.audio_settings_echo_tester_summary)
+        showEchoTester.value = prefs.debugLogs // Don't show echo tester unless debug mode is enabled, may confuse user over what it should be used for
+
         preferBluetoothDevices.value = prefs.routeAudioToBluetoothIfAvailable
         initInputAudioDevicesList()
         initOutputAudioDevicesList()
diff --git a/app/src/main/res/layout/settings_audio_fragment.xml b/app/src/main/res/layout/settings_audio_fragment.xml
index 520804313..f5bc360cb 100644
--- a/app/src/main/res/layout/settings_audio_fragment.xml
+++ b/app/src/main/res/layout/settings_audio_fragment.xml
@@ -80,6 +80,7 @@
 
                 <include
                     layout="@layout/settings_widget_basic"
+                    android:visibility="@{viewModel.showEchoTester ? View.VISIBLE : View.GONE, default=gone}"
                     linphone:title="@{@string/audio_settings_echo_tester_title}"
                     linphone:subtitle="@{viewModel.echoTesterStatus}"
                     linphone:listener="@{viewModel.echoTesterListener}"/>