fpga: altera: Make altera_validate return normal values
Make the function return either 0 or -EINVAL, that is, normal expected error codes and success codes instead of true/false nonsense. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Chin Liang See <clsee@altera.com> Cc: Dinh Nguyen <dinguyen@altera.com> Cc: Albert Aribaud <albert.u.boot@aribaud.net> Cc: Tom Rini <trini@ti.com> Cc: Wolfgang Denk <wd@denx.de> Cc: Pavel Machek <pavel@denx.de> Acked-by: Pavel Machek <pavel@denx.de>
This commit is contained in:
parent
54c96b18a2
commit
fda915a4cf
1 changed files with 9 additions and 9 deletions
|
@ -12,38 +12,38 @@
|
|||
* Altera FPGA support
|
||||
*/
|
||||
#include <common.h>
|
||||
#include <errno.h>
|
||||
#include <ACEX1K.h>
|
||||
#include <stratixII.h>
|
||||
|
||||
/* Define FPGA_DEBUG to 1 to get debug printf's */
|
||||
#define FPGA_DEBUG 0
|
||||
|
||||
/* Local Static Functions */
|
||||
static int altera_validate(Altera_desc *desc, const char *fn)
|
||||
{
|
||||
if (!desc) {
|
||||
printf("%s: NULL descriptor!\n", fn);
|
||||
return false;
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
if ((desc->family < min_altera_type) ||
|
||||
(desc->family > max_altera_type)) {
|
||||
printf("%s: Invalid family type, %d\n", fn, desc->family);
|
||||
return false;
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
if ((desc->iface < min_altera_iface_type) ||
|
||||
(desc->iface > max_altera_iface_type)) {
|
||||
printf("%s: Invalid Interface type, %d\n", fn, desc->iface);
|
||||
return false;
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
if (!desc->size) {
|
||||
printf("%s: NULL part size\n", fn);
|
||||
return false;
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
return true;
|
||||
return 0;
|
||||
}
|
||||
|
||||
/* ------------------------------------------------------------------------- */
|
||||
|
@ -51,7 +51,7 @@ int altera_load(Altera_desc *desc, const void *buf, size_t bsize)
|
|||
{
|
||||
int ret_val = FPGA_FAIL; /* assume a failure */
|
||||
|
||||
if (!altera_validate(desc, (char *)__func__)) {
|
||||
if (altera_validate(desc, (char *)__func__)) {
|
||||
printf("%s: Invalid device descriptor\n", __func__);
|
||||
return FPGA_FAIL;
|
||||
}
|
||||
|
@ -95,7 +95,7 @@ int altera_dump(Altera_desc *desc, const void *buf, size_t bsize)
|
|||
{
|
||||
int ret_val = FPGA_FAIL; /* assume a failure */
|
||||
|
||||
if (!altera_validate (desc, (char *)__func__)) {
|
||||
if (altera_validate(desc, (char *)__func__)) {
|
||||
printf("%s: Invalid device descriptor\n", __func__);
|
||||
return FPGA_FAIL;
|
||||
}
|
||||
|
@ -133,7 +133,7 @@ int altera_info(Altera_desc *desc)
|
|||
{
|
||||
int ret_val = FPGA_FAIL;
|
||||
|
||||
if (!altera_validate (desc, (char *)__func__)) {
|
||||
if (altera_validate (desc, (char *)__func__)) {
|
||||
printf("%s: Invalid device descriptor\n", __func__);
|
||||
return FPGA_FAIL;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue