Difuse/u-boot
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

driver: net: fsl-mc: fix error handing in init_phy

Browse source 
if an error occurs during init_phy, we should free the phydev structure
which has been allocated by phy_connect.

Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
This commit is contained in:
Pankaj Bansal 2018-10-10 14:08:31 +05:30 committed by Joe Hershberger
parent d75e81d9e0
commit f259c43d89
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/net/ldpaa_eth/ldpaa_eth.c
View file

@ -23,6 +23,7 @@ static int init_phy(struct eth_device *dev)
struct ldpaa_eth_priv *priv = (struct ldpaa_eth_priv *)dev->priv;
struct phy_device *phydev = NULL;
struct mii_dev *bus;
int ret;
bus = wriop_get_mdio(priv->dpmac_id);
if (bus == NULL)
@ -37,7 +38,14 @@ static int init_phy(struct eth_device *dev)
wriop_set_phy_dev(priv->dpmac_id, phydev);
return phy_config(phydev);
ret = phy_config(phydev);
if (ret) {
free(phydev);
wriop_set_phy_dev(priv->dpmac_id, NULL);
}
return ret;
}
#endif