Difuse/u-boot
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

net: move random_port() to dns

Browse source 
The random_port() routine is not used anywhere else. Make it local to
dns.c to reduce code clutter, and shrink generated code a little.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
This commit is contained in:
Baruch Siach 2020-05-20 13:31:41 +03:00 committed by Tom Rini
parent 0813921042
commit f1d925d9c3
3 changed files with 10 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
include/net.h
View file

@ -897,9 +897,6 @@ int is_serverip_in_cmd(void);
*/ */
int net_parse_bootfile(struct in_addr *ipaddr, char *filename, int max_len); int net_parse_bootfile(struct in_addr *ipaddr, char *filename, int max_len);
/* get a random source port */
unsigned int random_port(void);
/** /**
* update_tftp - Update firmware over TFTP (via DFU) * update_tftp - Update firmware over TFTP (via DFU)
* *

10
net/dns.c
View file

@ -36,6 +36,16 @@ char *net_dns_env_var; /* The envvar to store the answer in */
static int dns_our_port; static int dns_our_port;
/*
* make port a little random (1024-17407)
* This keeps the math somewhat trivial to compute, and seems to work with
* all supported protocols/clients/servers
*/
static unsigned int random_port(void)
{
return 1024 + (get_timer(0) % 0x4000);
}
static void dns_send(void) static void dns_send(void)
{ {
struct header *header; struct header *header;

14
net/net.c
View file

@ -1564,20 +1564,6 @@ int net_parse_bootfile(struct in_addr *ipaddr, char *filename, int max_len)
return 1; return 1;
} }
#if defined(CONFIG_CMD_NFS) || \
defined(CONFIG_CMD_SNTP) || \
defined(CONFIG_CMD_DNS)
/*
* make port a little random (1024-17407)
* This keeps the math somewhat trivial to compute, and seems to work with
* all supported protocols/clients/servers
*/
unsigned int random_port(void)
{
return 1024 + (get_timer(0) % 0x4000);
}
#endif
void ip_to_string(struct in_addr x, char *s) void ip_to_string(struct in_addr x, char *s)
{ {
x.s_addr = ntohl(x.s_addr); x.s_addr = ntohl(x.s_addr);