Difuse/u-boot
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

firmware: ti_sci: Remove inline keyword from functions

Browse source 
The inline hint is not needed here, the compiler will do the right thing
based on if we are compiling for speed or for code size. In this case the
inline causes this function to be placed inside each callsite which is
not the right thing to do for either speed nor size. There is no
performance benefit to this due to the larger function size reducing
cache locality, but there is a huge size penalty. Remove inline keyword.

Signed-off-by: Andrew Davis <afd@ti.com>
This commit is contained in:
Andrew Davis 2022-07-25 20:25:05 -05:00 committed by Tom Rini
parent 0d74f2684b
commit f127a58e05
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/firmware/ti_sci.c
View file

@ -164,7 +164,7 @@ static struct ti_sci_xfer *ti_sci_setup_one_xfer(struct ti_sci_info *info,
* return corresponding error, else if all goes well,
* return 0.
*/
static inline int ti_sci_get_response(struct ti_sci_info *info,
static int ti_sci_get_response(struct ti_sci_info *info,
struct ti_sci_xfer *xfer,
struct mbox_chan *chan)
{
@ -218,7 +218,7 @@ static inline int ti_sci_get_response(struct ti_sci_info *info,
*
* Return: 0 if all went fine, else return appropriate error.
*/
static inline int ti_sci_do_xfer(struct ti_sci_info *info,
static int ti_sci_do_xfer(struct ti_sci_info *info,
struct ti_sci_xfer *xfer)
{
struct k3_sec_proxy_msg *msg = &xfer->tx_message;
@ -310,7 +310,7 @@ static int ti_sci_cmd_get_revision(struct ti_sci_handle *handle)
*
* Return: true if the response was an ACK, else returns false.
*/
static inline bool ti_sci_is_response_ack(void *r)
static bool ti_sci_is_response_ack(void *r)
{
struct ti_sci_msg_hdr *hdr = r;