Difuse/u-boot
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

spi: spi-mem: perform odd len check only while writing data

Browse source 
in spi_mem_dtr_supports_op we have a check for allowing only even number
of bytes to be r/w. Odd bytes writing can be a concern while writing
data to a flash for example because 8 DTR mode doesn't support it.
However, reading ODD Bytes even  though may not be physically possible
we can still allow for it because it will not have serious implications
on any critical registers being overwritten since they are just reads.

Cc: Vaishnav Achath <vaishnav.a@ti.com>
Cc: Pratyush Yadav <pratyush@kernel.org>
Cc: Vignesh Raghavendra <vigneshr@ti.com>
Tested-by: Nikhil M Jain <n-jain1@ti.com>
Signed-off-by: Dhruva Gole <d-gole@ti.com>
Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
This commit is contained in:
Dhruva Gole 2023-03-01 13:13:46 +05:30 committed by Jagan Teki
parent 963b5da339
commit db58dc5438
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/spi/spi-mem.c
View file

@ -185,7 +185,7 @@ bool spi_mem_dtr_supports_op(struct spi_slave *slave,
* Transactions of odd length do not make sense for 8D-8D-8D mode
* because a byte is transferred in just half a cycle.
*/
if (op->data.dir != SPI_MEM_NO_DATA &&
if (op->data.dir != SPI_MEM_NO_DATA && op->data.dir != SPI_MEM_DATA_IN &&
op->data.buswidth == 8 && op->data.nbytes % 2)
return false;