Difuse/u-boot
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

virtio: pci: Bounds check device config access

Browse source 
The device config is optional, so check it was present and mapped before
trying to use the pointer. Bounds violations are an error, not just a
warning, so bail if the checks fail.

Signed-off-by: Andrew Scull <ascull@google.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
This commit is contained in:
Andrew Scull 2022-04-21 16:11:01 +00:00 committed by Tom Rini
parent da03cdfa7a
commit 94b28b9158
1 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
drivers/virtio/virtio_pci_modern.c
View file

@ -114,7 +114,11 @@ static int virtio_pci_get_config(struct udevice *udev, unsigned int offset,
__le16 w;
__le32 l;
WARN_ON(offset + len > priv->device_len);
if (!priv->device)
return -ENOSYS;
if (offset + len > priv->device_len)
return -EINVAL;
switch (len) {
case 1:
@ -136,7 +140,7 @@ static int virtio_pci_get_config(struct udevice *udev, unsigned int offset,
memcpy(buf + sizeof(l), &l, sizeof(l));
break;
default:
WARN_ON(true);
return -EINVAL;
}
return 0;
@ -150,7 +154,11 @@ static int virtio_pci_set_config(struct udevice *udev, unsigned int offset,
__le16 w;
__le32 l;
WARN_ON(offset + len > priv->device_len);
if (!priv->device)
return -ENOSYS;
if (offset + len > priv->device_len)
return -EINVAL;
switch (len) {
case 1:
@ -172,7 +180,7 @@ static int virtio_pci_set_config(struct udevice *udev, unsigned int offset,
iowrite32(le32_to_cpu(l), priv->device + offset + sizeof(l));
break;
default:
WARN_ON(true);
return -EINVAL;
}
return 0;