Difuse/u-boot
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

cmd: return code when tlv_eeprom incorrectly called

Browse source 
A command called with incorrect parameters should set $? to 1 (false).
Instead of calling cmd_usage(cmdtp) and then returning 0 just return
CMD_RET_FAILURE.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Reviewed-by: Stefan Roese <sr@denx.de>
This commit is contained in:
Heinrich Schuchardt 2023-01-27 22:49:10 +01:00 committed by Stefan Roese
parent a5e490f14e
commit 93a80c1515
1 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
cmd/tlv_eeprom.c
View file

@ -479,17 +479,14 @@ int do_tlv_eeprom(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
show_tlv_devices();
break;
default:
cmd_usage(cmdtp);
break;
return CMD_RET_USAGE;
}
return 0;
}
// The set command takes one or two args.
if (argc > 4) {
cmd_usage(cmdtp);
return 0;
}
if (argc > 4)
return CMD_RET_USAGE;
// Set command. If the TLV exists in the EEPROM, delete it. Then if
// data was supplied for this TLV add the TLV with the new contents at
@ -512,7 +509,7 @@ int do_tlv_eeprom(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
current_dev = devnum;
has_been_read = 0;
} else {
cmd_usage(cmdtp);
return CMD_RET_USAGE;
}
return 0;