Difuse/u-boot
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

net: ipv6: Fixed IPv6 string to address conversion off-by-one error

Browse source 
One extra character was being checked in the IPv6 string which caused the
last character of the address to be neither '\0' nor ':'. This raises an
error condition and causes the function to always return an error. This
issue was resolved by this fix.

Signed-off-by: Ehsan Mohandesi <emohandesi@microsoft.com>
Reviewed-by: Viacheslav Mitrofanov <v.v.mitrofanov@yadro.com>
This commit is contained in:
Ehsan Mohandesi 2023-01-13 09:27:41 -08:00 committed by Tom Rini
parent 796e549822
commit 7db25d99b2
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
net/tftp.c
View file

@ -845,7 +845,7 @@ void tftp_start(enum proto_t protocol)
e = strchr(net_boot_file_name, ']'); e = strchr(net_boot_file_name, ']');
len = e - s; len = e - s;
if (s && e) { if (s && e) {
string_to_ip6(s + 1, len, &tftp_remote_ip6); string_to_ip6(s + 1, len - 1, &tftp_remote_ip6);
strlcpy(tftp_filename, e + 2, MAX_LEN); strlcpy(tftp_filename, e + 2, MAX_LEN);
} else { } else {
strlcpy(tftp_filename, net_boot_file_name, MAX_LEN); strlcpy(tftp_filename, net_boot_file_name, MAX_LEN);