Difuse/u-boot
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

tools: Avoid leaving extra data at the end of copied files

Browse source 
The copyfile() implementation has strange behaviour if the destination
file already exists. Update it to ensure that any existing data in the
destination file is dropped.

Signed-off-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Simon Glass 2021-11-12 12:28:05 -07:00
parent e291a5c9a2
commit 7ae46c3579
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tools/fit_common.c
View file

@ -134,7 +134,7 @@ int copyfile(const char *src, const char *dst)
goto out;
}
fd_dst = open(dst, O_WRONLY | O_CREAT, 0666);
fd_dst = open(dst, O_WRONLY | O_CREAT | O_TRUNC, 0666);
if (fd_dst < 0) {
printf("Can't open file %s (%s)\n", dst, strerror(errno));
goto out;

2
tools/fit_common.h
View file

@ -44,6 +44,8 @@ int mmap_fdt(const char *cmdname, const char *fname, size_t size_inc,
*
* This uses read()/write() to copy file @src to file @dst
*
* If @dst exists, it is overwritten and truncated to the correct size.
*
* @src: Filename to read from
* @dst: Filename to write to
* @return 0 if OK, -1 on error