Difuse/u-boot
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

x86: coreboot: Show unimplemented sysinfo tags

Browse source 
Sometimes coreboot adds new tags that U-Boot does not know about. These
are silently ignored, but it is useful to at least know what we are
missing.

Add a way to collect this information. For Brya it shows:

   Unimpl. 38 41 37 34 42 40

These are:

   LB_TAG_PLATFORM_BLOB_VERSION
   LB_TAG_ACPI_CNVS
   LB_TAG_FMAP
   LB_TAG_VBOOT_WORKBUF
   LB_TAG_TYPE_C_INFO
   LB_TAG_BOARD_CONFIG

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Tested-by: Bin Meng <bmeng.cn@gmail.com>
This commit is contained in:
Simon Glass 2023-05-04 16:55:06 -06:00 committed by Bin Meng
parent ea45ee1fc3
commit 2f5210b703
3 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
arch/x86/include/asm/cb_sysinfo.h
View file

@ -16,6 +16,8 @@
#define SYSINFO_MAX_GPIOS 8 #define SYSINFO_MAX_GPIOS 8
/* Up to 10 MAC addresses */ /* Up to 10 MAC addresses */
#define SYSINFO_MAX_MACS 10 #define SYSINFO_MAX_MACS 10
/* Track the first 32 unimplemented tags */
#define SYSINFO_MAX_UNIMPL 32
/** /**
* struct sysinfo_t - Information passed to U-Boot from coreboot * struct sysinfo_t - Information passed to U-Boot from coreboot
@ -134,6 +136,8 @@
* @chromeos_vpd: Chromium OS Vital Product Data region, typically NULL, meaning * @chromeos_vpd: Chromium OS Vital Product Data region, typically NULL, meaning
* not used * not used
* @rsdp: Pointer to ACPI RSDP table * @rsdp: Pointer to ACPI RSDP table
* @unimpl_count: Number of entries in unimpl_map[]
* @unimpl: List of unimplemented IDs (bottom 8 bits only)
*/ */
struct sysinfo_t { struct sysinfo_t {
unsigned int cpu_khz; unsigned int cpu_khz;
@ -213,6 +217,8 @@ struct sysinfo_t {
u32 mtc_size; u32 mtc_size;
void *chromeos_vpd; void *chromeos_vpd;
void *rsdp; void *rsdp;
u32 unimpl_count;
u8 unimpl[SYSINFO_MAX_UNIMPL];
}; };
extern struct sysinfo_t lib_sysinfo; extern struct sysinfo_t lib_sysinfo;

2
arch/x86/lib/coreboot/cb_sysinfo.c
View file

@ -439,6 +439,8 @@ static int cb_parse_header(void *addr, int len, struct sysinfo_t *info)
cb_parse_acpi_rsdp(rec, info); cb_parse_acpi_rsdp(rec, info);
break; break;
default: default:
if (info->unimpl_count < SYSINFO_MAX_UNIMPL)
info->unimpl[info->unimpl_count++] = rec->tag;
cb_parse_unhandled(rec->tag, ptr); cb_parse_unhandled(rec->tag, ptr);
break; break;
} }

8
cmd/x86/cbsysinfo.c
View file

@ -364,6 +364,14 @@ static void show_table(struct sysinfo_t *info, bool verbose)
print_ptr("Chrome OS VPD", info->chromeos_vpd); print_ptr("Chrome OS VPD", info->chromeos_vpd);
print_ptr("RSDP", info->rsdp); print_ptr("RSDP", info->rsdp);
printf("%-12s: ", "Unimpl.");
if (info->unimpl_count) {
for (i = 0; i < info->unimpl_count; i++)
printf("%02x ", info->unimpl[i]);
printf("\n");
} else {
printf("(none)\n");
}
} }
static int do_cbsysinfo(struct cmd_tbl *cmdtp, int flag, int argc, static int do_cbsysinfo(struct cmd_tbl *cmdtp, int flag, int argc,