Difuse/u-boot
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

patman: encode CC list to UTF-8

Browse source 
This change encodes the CC list to UTF-8 to avoid failures on
maintainer-addresses that include non-ASCII characters (observed on
Debian 7.11 with Python 2.7.3).

Without this, I get the following failure:
  Traceback (most recent call last):
    File "tools/patman/patman", line 159, in <module>
      options.add_maintainers)
    File "[snip]/u-boot/tools/patman/series.py", line 234, in MakeCcFile
      print(commit.patch, ', '.join(set(list)), file=fd)
  UnicodeEncodeError: 'ascii' codec can't encode character u'\xfc' in position 81: ordinal not in range(128)
from Heiko's email address:
  [..., u'"Heiko St\xfcbner" <heiko@sntech.de>', ...]

While with this change added this encodes to:
  "=?UTF-8?q?Heiko=20St=C3=BCbner?= <heiko@sntech.de>"

Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Tested-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
This commit is contained in:
Philipp Tomsich 2017-05-29 15:31:22 -06:00 committed by Simon Glass
parent d5686a61d6
commit 21caa558ca
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tools/patman/series.py
View file

@ -119,7 +119,7 @@ class Series(dict):
email = col.Color(col.YELLOW, "<alias '%s' not found>" email = col.Color(col.YELLOW, "<alias '%s' not found>"
% tag) % tag)
if email: if email:
print(' Cc: ', email) print(' Cc: ', email.encode('utf-8'))
print print
for item in to_set: for item in to_set:
print('To:\t ', item) print('To:\t ', item)
@ -230,7 +230,7 @@ class Series(dict):
if add_maintainers: if add_maintainers:
list += get_maintainer.GetMaintainer(commit.patch) list += get_maintainer.GetMaintainer(commit.patch)
all_ccs += list all_ccs += list
print(commit.patch, ', '.join(set(list)), file=fd) print(commit.patch, ', '.join(set(list)).encode('utf-8'), file=fd)
self._generated_cc[commit.patch] = list self._generated_cc[commit.patch] = list
if cover_fname: if cover_fname: