Commit graph

29 commits

Author SHA1 Message Date
Tony Ambardar
442a19214b siproxd: fix UID variable conflict in init
Variable 'UID' is set readonly in some calling contexts, yielding errors
during e.g. ImageBuilder usage:

  Enabling rpcd
  ./etc/init.d/siproxd: line 14: UID: readonly variable
  Enabling siproxd
  Enabling sysctl

Rename UID and GID variables as SIPROXD_UID and SIPROXD_GID.

Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
2021-01-24 00:27:05 -08:00
Sebastian Kemper
8512b7395a siproxd: rev bump
Increases revision due to SONAME bump of libosip2.

Signed-off-by: Sebastian Kemper <sebastian_ml@gmx.net>
2020-10-03 18:52:36 +02:00
Tony Ambardar
37c411269b siproxd: add max clients configuration and default
Add a configuration option SIPROXD_MAX_CLIENTS used for compile-time sizing
of the maximum supported proxy clients. Set this to a default value of 32,
which is more suitable for a small network or CPE router and uses much
less memory than the upstream value of 512 (e.g. RSS of 2 MB vs 17 MB).

Drop the following patch in favour of the new config option:

  * 005-reduce-rtpproxy-urlmap-size.patch

Also fix an incorrect configure option, and silence many warnings due to
unused VCS 'ident' variables in the sources.

Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
2020-09-22 22:21:12 -07:00
Tony Ambardar
3fb223fa88 siproxd: update to version 0.8.3, improve logging and memory usage
This release includes bug fixes and improvements accumulated over the last
4 years of development snapshots [1].

Bump upstream version, build new plugins 'stats' and 'blacklist', and add
an 'sqlite3' package dependency for siproxd-mod-blacklist.

Disable procd capturing stderr to syslog, since siproxd in 'foreground'
mode writes both to syslog and stderr, duplicating log messages.

Include a patch to drastically reduce memory usage (RSS from 17MB to 5MB
on ipq40xx platform):

  * 005-reduce-rtpproxy-urlmap-size.patch

Drop the following patches now included upstream:

  * 010-syslog-msg.patch
  * 020-gcc10.patch
  * 100-musl-compat.patch

[1] http://siproxd.sourceforge.net/index.php?op=changelog.

Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
2020-09-04 22:38:33 -07:00
Rosen Penev
73ed049c1a
sixproxd: fix compilation with GCC 10
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-07-19 14:55:29 -07:00
guidosarducci
aac5a6f843 siproxd: capture debug output in syslog
Although siproxd normally logs to syslog, it's debug output appears to go
only to stderr. Adjust procd setup to also capture stderr in syslog.

Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
2018-12-08 16:53:08 -08:00
guidosarducci
aa2e7cdc3c siproxd: add OpenWrt siproxd wiki link to package info
This has the advantage of being available in the package catalog and
hence anytime both pre- and post-installation for someone looking for
information, using only the 'opkg info siproxd' command.

Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
2018-12-08 16:51:33 -08:00
guidosarducci
b65b20f6f8 siproxd: restructure code and use procd for init
Switch to use procd for init, with support for jails. Clean up code and
restructure callback processing to be more robust and understandable. This
also fixes a bug processing multiple siproxd config sections, as reported
by Michael Kuron.

Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
2018-05-24 00:23:56 -07:00
guidosarducci
a3f6f176d5 siproxd: don't apply default values already built-in
Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
2018-05-24 00:18:54 -07:00
Sebastian Kemper
a126cfcb74 siproxd: remove underscores from package names
Underscores should not be used in package base names as they're used as
semantic separators by opkg.

Signed-off-by: Sebastian Kemper <sebastian_ml@gmx.net>
2018-04-10 21:14:11 +02:00
guidosarducci
b5204f6d0d siproxd: improve syslog messages
Use explicit ident string ("siproxd") instead of NULL, as the latter is
not guaranteed to prepend the program name (e.g. unspecified in POSIX),
and may result in syslog messages identified only by PID.

Use consistent facility (LOG_DAEMON) across openlog() and syslog() calls.

Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
2018-03-17 18:41:10 -07:00
guidosarducci
ea47a982ac siproxd: add usage comments, examples to default UCI config
Explain default configuration options and potential firewall settings.
Provide examples of using documented siproxd configuration directives.

Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
2018-03-17 18:41:10 -07:00
guidosarducci
09f32fb1a5 siproxd: use UCI callback processing, reduce code size
Switch to using callback functions for UCI config processing, and remove
the unnecessary scan_interfaces() call together with related code.

Instead of explicitly handling every possible siproxd config option, use
callbacks to deal with those defined in the UCI config file, and directly
handle only selected options with desired default values. This shrinks
the init code by ~3.5 KB and simplifies updating to future siproxd
versions with new options.

(Note: this change exposed some long-standing, broken aspects of UCI
callback handling, fixed in https://github.com/openwrt/openwrt/pull/805.)

Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
2018-03-17 18:34:16 -07:00
Sebastian Kemper
b1cd5436d7 siproxd: update module install define
Use $(INSTALL_BIN) as the modules are installed by siproxd as
executables. Remove the wildcards from this line as they're not needed.

Signed-off-by: Sebastian Kemper <sebastian_ml@gmx.net>
2018-02-24 11:25:09 +01:00
Sebastian Kemper
67b6cc3221 siproxd: update libltdl handling
Remove LIBLTDL from the Makefile as well as a patch related to LTDL.
Both have in common that they accomplish absolutely nothing.

Also explicitly disable the use of the internal libltdl.

Signed-off-by: Sebastian Kemper <sebastian_ml@gmx.net>
2018-02-24 11:22:39 +01:00
guidosarducci
6fc399bb17 siproxd: use PKG_HASH and update copyright date
Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
2017-07-10 02:51:23 -07:00
guidosarducci
456d10459f siproxd: fix support for domain-specific proxies
Use lists for the config entries outbound_domain_{name,host,port}.

This permits multiple outbound proxies and fixes:
https://github.com/openwrt/telephony/issues/127

Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
2017-07-03 16:59:23 -07:00
guidosarducci
3e16420743 siproxd: update to version 0.8.2
An upstream siproxd update was released after ~5 years, with bugfixes
and new features. This package supports the new plugins and their config
options, and updates required patches.

Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
2017-07-03 16:59:23 -07:00
guidosarducci
055da10ad7 siproxd: use clearer runtime file and directory names
Use more conventional, clearer naming for config and registration files.
This includes having distinct directories and specific file suffixes.

Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
2017-07-03 16:59:23 -07:00
guidosarducci
84695bea0c siproxd: add shell helper function to build config file
Using the append_conf_if_set() function removes much repetitive and
error-prone code, reduces the source size by ~30%, and fixes a typo
previously uncaught.

Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
2017-07-03 16:59:04 -07:00
guidosarducci
ff3f6f8665 siproxd: clean up directory permissions, ownership
Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
2017-06-20 03:18:27 -07:00
guidosarducci
86615075b8 siproxd: use reasonable logging level by default
The previous default logging level is completely silent, making normal
monitoring or troubleshooting impossible. Use the sane upstream default
for logging which captures basic startup, shutdown and error messages.

Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
2017-06-20 03:18:27 -07:00
guidosarducci
347cdf07bf siproxd: use standard interface names by default
Support using standard interface names and make "lan"/"wan" the defaults
for inbound/outbound SIP traffic. This change makes siproxd more portable
but preserves backwards compatibility for upgrades.

Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
2017-06-20 03:18:27 -07:00
Jo-Philipp Wich
43c6d1e59e siproxd: fix musl compatibility
- Add missing `sys/types.h` include to provide `u_short` type under musl
 - Add missing `string.h` includes to avoid implicit function declarations

Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>
2015-06-25 17:44:13 +02:00
Jiri Slachta
88aeeaa3a2 Update a few of the PKG_LICENSE tags to be more accurate
Signed-off-by: Eric Schultz <eschultz@prplfoundation.org>
Signed-off-by: Jiri Slachta <slachta@cesnet.cz>
2014-11-05 21:54:40 +01:00
Jiri Slachta
a5b4c7d1f9 Add PKG_LICENSE variable to the most of the packages.
Signed-off-by: Jiri Slachta <slachta@cesnet.cz>
2014-11-04 16:00:37 +01:00
Jiri Slachta
d152bdf38a siproxd: fix missing sys/time.h
Signed-off-by: Jiri Slachta <slachta@cesnet.cz>
2014-07-18 21:06:48 +02:00
Jiri Slachta
4fc80c5f96 siproxd: fix typo in init script
Signed-off-by: Jiri Slachta <slachta@cesnet.cz>
2013-10-17 15:46:39 +02:00
Jiri Slachta
100f27f3bb Directory structure restructuralized.
Signed-off-by: Jiri Slachta <slachta@cesnet.cz>
2013-06-21 13:55:47 +02:00