ac806e9921
The proto_send_update function is sending a notification to netifd during the teardown section. However, netifd filters link update notifications executed during teardown, as indicated here: https://git.openwrt.org/?p=project/netifd.git;a=blob;f=proto-shell.c#l515 This was leading to a Permission Denied error due to its behavior, making proto_send_update ineffective during teardown. To address the issue, the proto_send_update function has been removed from the teardown section. This prevents the Permission Denied error while ensuring proper operation during teardown. Additionally, in the 10-report-down helper script, a check has been implemented to determine if the interface is already down. This check is crucial to avoid triggering a Permission Denied error, especially in cases where netifd is already aware of a controlled ifdown operation. Signed-off-by: Oliver Sedlbauer <osedlbauer@tdt.de>
40 lines
1,006 B
Bash
Executable file
40 lines
1,006 B
Bash
Executable file
#!/bin/sh
|
|
|
|
# SPDX-License-Identifier: CC0-1.0
|
|
# 2022 Aleksander Morgado <aleksander@aleksander.es>
|
|
#
|
|
# Automatically report to netifd that the underlying modem
|
|
# is really disconnected
|
|
#
|
|
# require program name and at least 4 arguments
|
|
[ $# -lt 4 ] && exit 1
|
|
|
|
MODEM_PATH="$1"
|
|
BEARER_PATH="$2"
|
|
INTERFACE="$3"
|
|
STATE="$4"
|
|
|
|
[ "${STATE}" = "disconnected" ] || exit 0
|
|
|
|
. /usr/share/ModemManager/modemmanager.common
|
|
. /lib/netifd/netifd-proto.sh
|
|
INCLUDE_ONLY=1 . /lib/netifd/proto/modemmanager.sh
|
|
|
|
MODEM_STATUS=$(mmcli --modem="${MODEM_PATH}" --output-keyvalue)
|
|
[ -n "${MODEM_STATUS}" ] || exit 1
|
|
|
|
MODEM_DEVICE=$(modemmanager_get_field "${MODEM_STATUS}" "modem.generic.device")
|
|
[ -n "${MODEM_DEVICE}" ] || exit 2
|
|
|
|
CFG=$(mm_get_modem_config "${MODEM_DEVICE}")
|
|
[ -n "${CFG}" ] || exit 3
|
|
|
|
IFUP=$(ifstatus "${CFG}" | jsonfilter -e "@.up")
|
|
|
|
[ "${IFUP}" = "true" ] && {
|
|
logger -t "modemmanager" "interface ${CFG} (network device ${INTERFACE}) ${STATE}"
|
|
proto_init_update $INTERFACE 0
|
|
proto_send_update $CFG
|
|
}
|
|
|
|
exit 0
|