20685f5220
Well, they're not yet compiled, but in the next commit they should be. People have been complaining [citation needed] to me via email or via Github that Python's performance is crap because it packages sources directly and they're not compiled. And Python has to compile the sources on each run, and on-the-fly. Allowing compilation caching is also a no-no, because I'll get complaints that the flash storage fills up whenever a Python app runs. So, to give the user a choice, the new de-facto packaging for Python packages will be: * ship compiled + [ preferably ] optimized files * package sources separately The problem is that this doubles the number of packages in LEDE/OpenWrt, but build-times should not suffer a big hit, since the compilation is done once, and the install phase should not be too intensive. Oh, and people don't need ship source packages if they don't want to. To do that, a packager needs to just call `$(eval $(call BuildPackage,python-<package>-src))` The `python-` prefix is important. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
70 lines
1.8 KiB
Bash
70 lines
1.8 KiB
Bash
#!/bin/sh
|
|
|
|
process_filespec() {
|
|
local src_dir="$1"
|
|
local dst_dir="$2"
|
|
local filespec="$3"
|
|
echo "$filespec" | (
|
|
IFS='|'
|
|
while read fop fspec fperm; do
|
|
local fop=`echo "$fop" | tr -d ' \t\n'`
|
|
if [ "$fop" = "+" ]; then
|
|
if [ ! -e "${src_dir}${fspec}" ]; then
|
|
echo "File not found '${src_dir}${fspec}'"
|
|
exit 1
|
|
fi
|
|
dpath=`dirname "$fspec"`
|
|
if [ -z "$fperm" ]; then
|
|
dperm=`stat -c "%a" ${src_dir}${dpath}`
|
|
fi
|
|
mkdir -p -m$dperm ${dst_dir}${dpath}
|
|
echo "copying: '$fspec'"
|
|
cp -fpR ${src_dir}${fspec} ${dst_dir}${dpath}/
|
|
if [ -n "$fperm" ]; then
|
|
chmod -R $fperm ${dst_dir}${fspec}
|
|
fi
|
|
elif [ "$fop" = "-" ]; then
|
|
echo "removing: '$fspec'"
|
|
rm -fR ${dst_dir}${fspec}
|
|
elif [ "$fop" = "=" ]; then
|
|
echo "setting permissions: '$fperm' on '$fspec'"
|
|
chmod -R $fperm ${dst_dir}${fspec}
|
|
fi
|
|
done
|
|
)
|
|
}
|
|
|
|
src_dir="$1"
|
|
dst_dir="$2"
|
|
python="$3"
|
|
mode="$4"
|
|
filespec="$5"
|
|
|
|
process_filespec "$src_dir" "$dst_dir" "$filespec" || {
|
|
echo "process filespec error-ed"
|
|
exit 1
|
|
}
|
|
|
|
if [ "$mode" == "sources" ] ; then
|
|
# Copy only python source files
|
|
find $dst_dir -not -name "*\.py" | xargs rm -f
|
|
# Delete empty folders (if the case)
|
|
find $dst_dir/usr -type d | xargs rmdir &> /dev/null
|
|
rmdir $dst_dir/usr &> /dev/null
|
|
exit 0
|
|
fi
|
|
|
|
# XXX [So that you won't goof as I did]
|
|
# Note: Yes, I tried to use the -O & -OO flags here.
|
|
# However the generated byte-codes were not portable.
|
|
# So, we just stuck to un-optimized byte-codes,
|
|
# which is still way better/faster than running
|
|
# Python sources all the time.
|
|
$python -m compileall -d '/' $dst_dir || {
|
|
echo "python -m compileall err-ed"
|
|
exit 1
|
|
}
|
|
# Delete source files and pyc [ un-optimized bytecode files ]
|
|
# We may want to make this optimization thing configurable later, but not sure atm
|
|
find $dst_dir -name "*\.py" | xargs rm -f
|
|
|