Difuse/packages
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

syslog-ng: improve init and fix service stop

Browse source 
This fixes service stop. Problem was that in default syslog-ng forks to
background which causes procd to loose track of it. It no longer has in
such case PID of syslog-ng process and is unable to stop it. This means
that instance for such process hangs in procd and also it is not
possible to stop it as daemon. Fix is simple. syslog-ng is now
instructed to run in foreground.

This commit also drops unnecessary reload section. In default reload
calls restart and restart in default is implemented as calling stop and
start. This means that effectively it is implemented same as in case of
this init reload service implementation.

Signed-off-by: Karel Kočí <karel.koci@nic.cz>
This commit is contained in:
Karel Kočí 2019-06-10 09:40:44 +02:00
parent 96df1c380f
commit 44a16ca325
No known key found for this signature in database
GPG key ID: D83BD732AC2BD828
2 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
admin/syslog-ng/Makefile
View file

@ -2,7 +2,7 @@ include $(TOPDIR)/rules.mk
PKG_NAME:=syslog-ng PKG_NAME:=syslog-ng
PKG_VERSION:=3.21.1 PKG_VERSION:=3.21.1
PKG_RELEASE:=1 PKG_RELEASE:=2
PKG_MAINTAINER:=Josef Schlehofer <josef.schlehofer@nic.cz> PKG_MAINTAINER:=Josef Schlehofer <josef.schlehofer@nic.cz>
PKG_LICENSE:=LGPL-2.1+ PKG_LICENSE:=LGPL-2.1+

9
admin/syslog-ng/files/syslog-ng.init
View file

@ -1,5 +1,5 @@
#!/bin/sh /etc/rc.common #!/bin/sh /etc/rc.common
# Copyright (C) 2006-2016 OpenWrt.org # Copyright (C) 2006-2019 OpenWrt.org
START=50 START=50
@ -8,11 +8,6 @@ USE_PROCD=1
start_service() { start_service() {
[ -f /etc/syslog-ng.conf ] || return 1 [ -f /etc/syslog-ng.conf ] || return 1
procd_open_instance procd_open_instance
procd_set_param command /usr/sbin/syslog-ng procd_set_param command /usr/sbin/syslog-ng --foreground
procd_close_instance procd_close_instance
} }
reload_service() {
stop
start
}