Difuse/packages
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

treewide: fix places where $(FPIC) is unquoted

Browse source 
Fixes part of issue #14921.

When $(FPIC) gets added to TARGET_CFLAGS (for instance), we can
count on $(TARGET_CFLAGS) in turn being quoted when it gets
expanded.  But there are a few places where $(FPIC) gets
expanded directly into environment variables passed on the
command line, such as when setting lt_cv_* variables as in this
case.

It's wrong to assume that the expansion of $(FPIC) won't require
quoting (such as it containing spaces) if it has multiple compiler
flags.

Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
This commit is contained in:
Philip Prindeville 2021-03-19 16:26:31 -06:00
parent 1e0eaa1f4c
commit 0d5c6769f1
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
libs/libredblack/Makefile
View file

@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
PKG_NAME:=libredblack PKG_NAME:=libredblack
PKG_VERSION:=1.3 PKG_VERSION:=1.3
PKG_RELEASE:=3 PKG_RELEASE:=4
PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
PKG_SOURCE_URL:=@SF/libredblack PKG_SOURCE_URL:=@SF/libredblack
@ -38,7 +38,7 @@ define Package/libredblack/description
endef endef
CONFIGURE_ARGS += --without-rbgen CONFIGURE_ARGS += --without-rbgen
CONFIGURE_VARS += lt_cv_prog_cc_pic=$(FPIC) CONFIGURE_VARS += lt_cv_prog_cc_pic="$(FPIC)"
MAKE_FLAGS += CFLAGS="$(TARGET_CFLAGS)" MAKE_FLAGS += CFLAGS="$(TARGET_CFLAGS)"
define Build/InstallDev define Build/InstallDev

4
sound/madplay/Makefile
View file

@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
PKG_NAME:=madplay PKG_NAME:=madplay
PKG_VERSION:=0.15.2b PKG_VERSION:=0.15.2b
PKG_RELEASE:=9 PKG_RELEASE:=10
PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
PKG_SOURCE_URL:=@SF/mad \ PKG_SOURCE_URL:=@SF/mad \
@ -51,7 +51,7 @@ CONFIGURE_ARGS += \
--with-alsa --with-alsa
CONFIGURE_VARS += \ CONFIGURE_VARS += \
lt_prog_compiler_pic=$(FPIC) lt_prog_compiler_pic="$(FPIC)"
MAKE_FLAGS += CFLAGS="$(TARGET_CFLAGS)" MAKE_FLAGS += CFLAGS="$(TARGET_CFLAGS)"