Localize the `authenticatior()` and `session_retrieve()` functions into the
`index()` function scope so that they're retained when extracting the
function into the dispatcher bytecode cache.
Also allow access to the global scope since upvalues do not work reliably
due to the out-of-context byte code caching of index functions.
Fixes https://github.com/openwrt/luci/issues/1300#issuecomment-381352765
Fixes feefc600e
("luci-mod-rpc: rework authentication and session handling")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
184 lines
4.8 KiB
Lua
184 lines
4.8 KiB
Lua
-- Copyright 2008 Steven Barth <steven@midlink.org>
|
|
-- Copyright 2008 Jo-Philipp Wich <jow@openwrt.org>
|
|
-- Licensed to the public under the Apache License 2.0.
|
|
|
|
module("luci.controller.rpc", package.seeall)
|
|
|
|
|
|
function index()
|
|
local function session_retrieve(sid, allowed_users)
|
|
local util = require "luci.util"
|
|
local sdat = util.ubus("session", "get", {
|
|
ubus_rpc_session = sid
|
|
})
|
|
|
|
if type(sdat) == "table" and
|
|
type(sdat.values) == "table" and
|
|
type(sdat.values.token) == "string" and
|
|
type(sdat.values.secret) == "string" and
|
|
type(sdat.values.username) == "string" and
|
|
util.contains(allowed_users, sdat.values.username)
|
|
then
|
|
return sid, sdat.values
|
|
end
|
|
|
|
return nil
|
|
end
|
|
|
|
local function authenticator(validator, accs)
|
|
local http = require "luci.http"
|
|
local auth = http.formvalue("auth", true) or http.getcookie("sysauth")
|
|
|
|
if auth then -- if authentication token was given
|
|
local sid, sdat = session_retrieve(auth, accs)
|
|
if sdat then -- if given token is valid
|
|
return sdat.username, sid
|
|
end
|
|
http.status(403, "Forbidden")
|
|
end
|
|
end
|
|
|
|
local rpc = node("rpc")
|
|
rpc.sysauth = "root"
|
|
rpc.sysauth_authenticator = authenticator
|
|
rpc.notemplate = true
|
|
|
|
entry({"rpc", "uci"}, call("rpc_uci"))
|
|
entry({"rpc", "fs"}, call("rpc_fs"))
|
|
entry({"rpc", "sys"}, call("rpc_sys"))
|
|
entry({"rpc", "ipkg"}, call("rpc_ipkg"))
|
|
entry({"rpc", "auth"}, call("rpc_auth")).sysauth = false
|
|
end
|
|
|
|
function rpc_auth()
|
|
local jsonrpc = require "luci.jsonrpc"
|
|
local http = require "luci.http"
|
|
local sys = require "luci.sys"
|
|
local ltn12 = require "luci.ltn12"
|
|
local util = require "luci.util"
|
|
|
|
local server = {}
|
|
server.challenge = function(user, pass)
|
|
local config = require "luci.config"
|
|
local login = util.ubus("session", "login", {
|
|
username = user,
|
|
password = pass,
|
|
timeout = tonumber(config.sauth.sessiontime)
|
|
})
|
|
|
|
if type(login) == "table" and
|
|
type(login.ubus_rpc_session) == "string"
|
|
then
|
|
util.ubus("session", "set", {
|
|
ubus_rpc_session = login.ubus_rpc_session,
|
|
values = {
|
|
token = sys.uniqueid(16),
|
|
secret = sys.uniqueid(16)
|
|
}
|
|
})
|
|
|
|
local sid, sdat = session_retrieve(login.ubus_rpc_session, { user })
|
|
if sdat then
|
|
return {
|
|
sid = sid,
|
|
token = sdat.token,
|
|
secret = sdat.secret
|
|
}
|
|
end
|
|
end
|
|
|
|
return nil
|
|
end
|
|
|
|
server.login = function(...)
|
|
local challenge = server.challenge(...)
|
|
if challenge then
|
|
http.header("Set-Cookie", 'sysauth=%s; path=%s' %{
|
|
challenge.sid,
|
|
http.getenv("SCRIPT_NAME")
|
|
})
|
|
return challenge.sid
|
|
end
|
|
end
|
|
|
|
http.prepare_content("application/json")
|
|
ltn12.pump.all(jsonrpc.handle(server, http.source()), http.write)
|
|
end
|
|
|
|
function rpc_uci()
|
|
if not pcall(require, "luci.model.uci") then
|
|
luci.http.status(404, "Not Found")
|
|
return nil
|
|
end
|
|
local uci = require "luci.jsonrpcbind.uci"
|
|
local jsonrpc = require "luci.jsonrpc"
|
|
local http = require "luci.http"
|
|
local ltn12 = require "luci.ltn12"
|
|
|
|
http.prepare_content("application/json")
|
|
ltn12.pump.all(jsonrpc.handle(uci, http.source()), http.write)
|
|
end
|
|
|
|
function rpc_fs()
|
|
local util = require "luci.util"
|
|
local io = require "io"
|
|
local fs2 = util.clone(require "nixio.fs")
|
|
local jsonrpc = require "luci.jsonrpc"
|
|
local http = require "luci.http"
|
|
local ltn12 = require "luci.ltn12"
|
|
|
|
function fs2.readfile(filename)
|
|
local stat, mime = pcall(require, "mime")
|
|
if not stat then
|
|
error("Base64 support not available. Please install LuaSocket.")
|
|
end
|
|
|
|
local fp = io.open(filename)
|
|
if not fp then
|
|
return nil
|
|
end
|
|
|
|
local output = {}
|
|
local sink = ltn12.sink.table(output)
|
|
local source = ltn12.source.chain(ltn12.source.file(fp), mime.encode("base64"))
|
|
return ltn12.pump.all(source, sink) and table.concat(output)
|
|
end
|
|
|
|
function fs2.writefile(filename, data)
|
|
local stat, mime = pcall(require, "mime")
|
|
if not stat then
|
|
error("Base64 support not available. Please install LuaSocket.")
|
|
end
|
|
|
|
local file = io.open(filename, "w")
|
|
local sink = file and ltn12.sink.chain(mime.decode("base64"), ltn12.sink.file(file))
|
|
return sink and ltn12.pump.all(ltn12.source.string(data), sink) or false
|
|
end
|
|
|
|
http.prepare_content("application/json")
|
|
ltn12.pump.all(jsonrpc.handle(fs2, http.source()), http.write)
|
|
end
|
|
|
|
function rpc_sys()
|
|
local sys = require "luci.sys"
|
|
local jsonrpc = require "luci.jsonrpc"
|
|
local http = require "luci.http"
|
|
local ltn12 = require "luci.ltn12"
|
|
|
|
http.prepare_content("application/json")
|
|
ltn12.pump.all(jsonrpc.handle(sys, http.source()), http.write)
|
|
end
|
|
|
|
function rpc_ipkg()
|
|
if not pcall(require, "luci.model.ipkg") then
|
|
luci.http.status(404, "Not Found")
|
|
return nil
|
|
end
|
|
local ipkg = require "luci.model.ipkg"
|
|
local jsonrpc = require "luci.jsonrpc"
|
|
local http = require "luci.http"
|
|
local ltn12 = require "luci.ltn12"
|
|
|
|
http.prepare_content("application/json")
|
|
ltn12.pump.all(jsonrpc.handle(ipkg, http.source()), http.write)
|
|
end
|