LuCI - OpenWrt Configuration Interface
0cb0742818
As I've brought up on the mailing list thread "High latency caused by full tree creation", there is a large amount of delay per LuCI request which is spent building the node tree in createtree(). Most nodes created aren't
needed for the view presented to the user and only serve to consume memory and CPU time during a page load.
My idea is to provide an easy mechanism for index()ers to determine which needs to be created and what isn't. Due to the constraints of the standard LuCI web interface, this optimization needs to establish a few rules:
* The page requested must have its node created
* All parents of the page being requested must be created, so the children inherit the track
* All the top-level nodes "Status", "System", "Services", "Network" (and others added by extensions) must be created in order to have their top-level tabs in the UI
* All peers of second-level nodes need to be created as well for the same reason, to display their links on the subindexes
To make this easy to implement in each controller, the attached patch adds an "inreq" field to each created node to indicate if it lies on the request path. To satisfy the "top level node" requirement, we always
add the top level node, then check its inreq property if the top-level node is not "in request", then the controller can exit index() early.
|
||
|---|---|---|
| applications | ||
| build | ||
| contrib | ||
| i18n | ||
| libs | ||
| modules | ||
| po | ||
| themes | ||
| .buildpath | ||
| .cproject | ||
| .gitignore | ||
| .project | ||
| INSTALL | ||
| LICENSE | ||
| Makefile | ||
| NOTICE | ||
| THANKYOU | ||