Commit graph

29 commits

Author SHA1 Message Date
Hannu Nyman
f7e5b56649 luci-app-statistics: Adjust UI defaults to match config file
Adjust the defaults shown in the LuCI user interface to match
the real default values in the default config file.

(If a plugin is disabled and config values get deleted from
the config file, user has been offered incorrect default
values from UI defaults when the plugin is later re-enabled.)

* dns: set br-lan as the interface
* email: socket in /var/run/collectd/ dir
* interface: set br-lan as the interface
* ping: TTL 127, interval 30
* rrdtool: 1hour as shortest period, 144 RRArows
* tcpconns: Do not monitor all, only 22 80
* unixsock: socket in /var/run/collectd/ dir

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2020-12-13 11:23:09 +02:00
Nick Hainke
f8552afb1c luci-app-statistics: add dhcpleases
Add the dhcpleases plugin:
https://github.com/openwrt/packages/pull/14204

Added-Frontend-by: Hannu Nyman <hannu.nyman@iki.fi>
Signed-off-by: Nick Hainke <vincent@systemli.org>

[Minor changes to graph: alt_autoscale, precision, label]
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2020-12-12 18:29:54 +02:00
Hannu Nyman
1cff100221 luci-app-statistics: CPU plugin: hide 'idle', tweak defaults
* Add functionality to hide the metric of 'idle' state
  from the chart and data table. Many routers are mostly idle,
  and the 98% 'idle' dominates the graph reducing its usefulness.
  Without 'idle', the smaller CPU usage spikes are visible.

* Hide 'idle' by default. Provide config option to show it.
  (note: the option in inside LuCI, and has no impact on actual
   data collection by collectd.)

* Tweak the defaults to use the percentage data by default.
  It makes more sense to average users than jiffies.

* Set the current LuCI defaults also in the config file.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2020-11-08 09:29:03 +02:00
Hannu Nyman
b95ac83ffd luci-app-statistics: fix comment
Update comment to reflect 'noavg' option introduced by 64bb82d03

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2020-09-08 08:21:55 +03:00
Florian Eckert
4d3f61d7c7 luci-app-statistics: add noavg option
It is sometimes useful not to display avg values int the graph.
This option is used to prevent this from appearing in the graph.
In a graph definition this option must be set to *true*,
 if the avg values should not be displayed.

```
options = {
	gauge = {
		title = "Status",
		color = "0000ff",
		noarea = true,
		noavg = true
	}
```

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
2020-09-08 07:57:35 +03:00
Florian Eckert
7a2b8174cc luci-app-statistics: add missing ValuesPercentage option
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
2020-07-13 13:32:52 +02:00
Hannu Nyman
4f80f9542f luci-app-statistics: remove quotemark from comment
Apparently " in a comment may cause an error in some conditions.
Reference to issue #4020

Remove also ";" just in case...

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2020-05-06 18:14:25 +03:00
Kevin Darbyshire-Bryant
9c4f3454d2 luci-app-statistics: add graphs for sqm-collect
Add graphs for sqm data collected by 'sqm_collect.sh'

An overall sqm graph displays bandwidth (Kb/s), Backlog (Bytes) and
drops for each supported qdisc.

Sqm-cake supports cake's tin structure and displays many(!) graphs per
tin:

Bandwidth: Bandwidth (Kb/s), bandwidth threshold (Kb/s).
Latency: Target latency, Peak, Average, Sparse flow latency
Backlog v Drops: Backlog (Bytes), Drops, ECN marks, Ack-filter drops
Flow counts: Sparse flows, Bulk flows, Unresponsive flows

Fun for all the family :-)

Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
2020-05-05 12:02:01 +01:00
Tobias Waldvogel
7eb63dfc27 luci-app-statistics: add syslog plugin
Signed-off-by: Tobias Waldvogel <tobias.waldvogel@gmail.com>
2020-04-21 18:36:56 +02:00
Tobias Waldvogel
9277333930 Add missing variable declaration for luci_app_statistics plugin df
Signed-off-by: Tobias Waldvogel <tobias.waldvogel@gmail.com>
2020-04-18 15:27:54 +02:00
ce-4
4be05a5fb8 luci-app-statistics: splash_leases.js: fix typo in configSummary string
Suggested-by: ce-4 <chr.egger@gmail.com>
[reword commit subject]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-08 09:05:13 +02:00
Jo-Philipp Wich
3c4bc228a1 treewide: import utility classes explicitly
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-03 10:00:06 +02:00
Jo-Philipp Wich
3d96519592 luci-app-statistics: minor bugfixes in IRQ and OpenVPN plugin config
- Fix cfgvalue loading in IRQ selection
 - Fix cfgbalue loading in OpenVPN status file selection
 - Fix typo in OpenVPN config translation string

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-29 14:17:55 +02:00
Jo-Philipp Wich
6d17667524 luci-app-statistics: rework markup and CSS classes for easier styling
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-23 22:19:26 +01:00
Jo-Philipp Wich
12e1d9411d luci-app-statistics: fix APC UPS graph rendering
Fixes: #3743
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-16 12:11:01 +01:00
Kevin Darbyshire-Bryant
7b52ff85a7 luci-app-statistics: conntrack: add percent usage graph
The existing graph shows a conntrack entry usage value but doesn't show
a conntrack table size figure so you don't know if you're close to
filling the table.  Add a percent usage graph to show conntrack table
percent used.

Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
2020-03-02 10:04:01 +00:00
Jo-Philipp Wich
0c3ce36ea8 luci-app-statistics: cpufreq: re-add ExtraItems config
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-02-23 12:10:35 +01:00
Jo-Philipp Wich
72da3c4c55 luci-app-statistics: rearrange graph display
- Add a per-plugin overview tab that contains the (non-detail) graphs of
   each plugin instance, similar to the old Lua based implementation
 - Numerically order plugin instances starting with numbers
 - Avoid multiple renderings of the same graphs
 - Fix legend of tcpconns graphs
 - Move cpufreq distribution and transition charts to detail tabs

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-02-22 23:32:44 +01:00
Jo-Philipp Wich
d4a475163e luci-app-statistics: clean and fix plugin configurations
- Remove redundant form flags
 - Fix various default values
 - Add some new collect options and remove options that do not exist anymore

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-02-22 23:26:49 +01:00
Jo-Philipp Wich
96dcae3a34 luci-app-statistics: use stable random seed for dynamic graph colors
Fixes: #3666
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-02-21 23:01:22 +01:00
Jo-Philipp Wich
27d63e7e71 luci-app-statistics: iptables.js: fix rule match expression
Fixes: #3658
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-02-21 08:57:29 +01:00
Jo-Philipp Wich
c16f91ccb9 luci-app-statistics: df.js: fix null access in configSummary()
Fixes: #3657
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-02-21 08:57:29 +01:00
Jo-Philipp Wich
756c894d70 luci-app-statistics: fix graph power/noise ordering
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-02-20 14:35:20 +01:00
Jo-Philipp Wich
4b1a43fc86 luci-app-statistics: fix data source ordering
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-02-20 13:48:20 +01:00
Jo-Philipp Wich
eec30a2b7d luci-app-statistics: fix datasource selection in graph rendering
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-02-19 14:28:35 +01:00
Jo-Philipp Wich
56e77ab817 luci-app-statistics: auto-create missing plugin entries
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-02-14 12:11:00 +01:00
Jo-Philipp Wich
c71ae18671 luci-app-statistics: config ui tweaks
- Synchronize enabled checkboxes in overview and modals
  - Auto-open modal if enabling plugin with extended config

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-02-14 11:39:28 +01:00
Jo-Philipp Wich
9680fdea9e luci-app-statistics: convert graph rendering to client side js
This conversion requires cgi-io >= version 17 and uhttpd version >= 2020-02-12
to function properly.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-02-13 20:45:26 +01:00
Jo-Philipp Wich
e7d22dce50 luci-app-statistics: convert collectd configuration to client side views
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-02-12 11:59:41 +01:00