Revert to the previous uci-defaults behaviour of only setting the
selected theme to Bootstrap if the Bootstrap entry didn't exist yet
in the configuration.
Ref: https://forum.openwrt.org/t/luci-theme-behaviour-change/112047
Fixes: ed86f03a9f ("luci-theme-bootstrap: add explicit dark/light mode selection")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 0bc09cc749)
Register two further "virtual" themes called BootstrapDark and
BootstrapLight which force dark and light mode respectively.
The actual Bootstrap theme itself will continue to auto-select
dark mode preference based on OS/Browser preference settings.
Fixes: #5492
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit ed86f03a9f)
Fixed overlay display failures for users on mobile, or users who booted
up in safe mode XD. Noticeable when vertical or horizontal real-estate
is too small for the displayed overlay.
This failure is most evident when you "edit" an interface, or display
your unsaved changes.
When content is wider than the screen view, the table hugs the (widest)
content maximally, and the overlay window becomes scrollable.
Disabled -webkit-overflow-scrolling, left, and right, because both FF
and Safari disable them as invalid anyway.
Signed-off-by: Paul Dee <systemcrash@users.noreply.github.com>
[Merge duplicate modal declarations, remove not applicable modal
flexbox properties]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit d1035c1f69)
- introduce new variable --text-color-highest which results in #000/#fff
for bright and dark modes respectively
- drop unused navigation style rules and selectors
- use sticky positioning for header bar and drop top margin hacks
- use flex box layout for header bar contents
- use uniform line-height for button elements instead of pixel paddings
- fix too bright .cbi-value bottom border in mobile dark mode
- avoid rendering duplicate .cbi-value bottom borders for nested sections
- simplify header markup, get rid of unused container elements
- use non-wrapping flex box layout for page actions, prioritize primary
action button in automatic width calculation
- fix border radius of ifacebox headers
- use brightest color for log output textareas
- fix dark mode colors for mode menu
- use flex layout for footer
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 588e24f9ca)
Add a dark theme variant which is enabled by default when
prefers-color-scheme is set to dark.
Signed-off-by: Teoh Han Hui <teohhanhui@gmail.com>
(cherry picked from commit 6dd71eaebe)
Currently it's not possible to distinguish between normal text and
hyperlink.
Signed-off-by: Petr Štetiar <ynezz@true.cz>
(cherry picked from commit 60fbadfa36)
Remove line-height css for syslog textarea as it cause some
problem with displaying all the rows of the syslog.
(Row line are calculated with a line-height of 1)
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
(cherry picked from commit a9ff8d3468)
- Drop jquery lib
- Move to the new menu.js implementation
- Rework css to mimic old js transition
- Rework footer and header to new implementation
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
(cherry picked from commit 031424c0d3)
they are to small for devices like e8450
as it has 4x LAN + 2x WLAN + 1x Bridge
Signed-off-by: Fritz D. Ansel <fdansel@yandex.ru>
(cherry picked from commit c592ef4f84)
Target table, tr, th and td tags directly and stop using the corresponding
CSS class names.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 7057108400)
The still referenced help.gif icon is absent by default since it has been
moved to luci-compat.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 6960819997)
Using the scalable graphic in place of the static png file saves some
ressources in flash and network. It also aligns the filetype to the type
announced to the browser.
fixes GitHub-issue #5051
Signed-off-by: Sven Roederer <freifunk@it-solutions.geroedel.de>
(cherry picked from commit 184e93df5f)
This calls striptags() on the hostname to prevent any XSS over the
hostname. This should fix CVE-2021-33425 as far as I understood it.
If someone adds some Javascript into system.@system[0].hostname it would
have been directly added to the page, this prevents the problem.
This can only be exploited by someone being able to modify the uci
configuration, normally a user with such privileges could also just
modify the webpage.
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
(cherry picked from commit 5cbd79d7e3)
Before fixed, if we have two nodes: 'services/ddns' and 'services/ddnsto',
click any one of they, will show they all actived.
Signed-off-by: Liangbin Lian <jjm2473@gmail.com>
(cherry picked from commit 97d50d2c6b)
Legacy Lua views might declare a global `css` variable to inject custom
styles into the template header. Support this mechanism in the OpenWrt 2020
theme as well.
Ref: https://github.com/openwrt/luci/issues/4972
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit c5ff3244e9)
Fix table rendering in the small responsive breakpoint on Safari (which
ignores `display: block;` for `<td>` elements).
Signed-off-by: Bryan Forbes <bryan@reigndropsfall.net>
The Rosy theme has been marked broken for over a year,
since 23 Dec 2019. Remove it now, so that it does not
get into the next release branch 20.xx (or 21.xx).
Reference to
https://github.com/openwrt/luci/issues/3759#issuecomment-599436159
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
After moving section title from `legend`, which was translated to `span`
with style `panel-title`, to `h3`, update also CSS style to match first
`h3` in `cbi-section`.
Signed-off-by: Oldřich Jedlička <oldium.pro@gmail.com>
Remove the reference to setting a password being linked to SSH capability.
(SSH has been initially enabled since year 2015.)
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
In the Material theme, clicking on the logo takes you to the status page.
This seems logical, and is very helpful. But in OpenWrt 2020, clicking on
the hostname doesn't do anything, so just pulling the same href from Material
so the link works in this theme as well.
Signed-off-by: Russell Morris <rmorris@rkmorris.us>
[adjust subject, commit message]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
In the Material theme, clicking on the logo takes you to the status page.
This seems logical, and is very helpful. But in Bootstrap, it doesn't
do anything, so just pulling the same href from Material to Bootstrap,
so the link works in Bootstrap as well.
Signed-off-by: Russell Morris <rmorris@rkmorris.us>
[adjust commit subject, squash commits]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
If we build multi-themes into firmware, each of them set itself
to be the default theme, what theme should it be?
To make it clear, we only set mediaurlbase if the theme is the
first time to be installed/built-in.
This resolve the issue that theme always change to somewhat default
after upgrading the firmware even with a config-keep-upgrade
Signed-off-by: Chen Minqiang <ptpt52@gmail.com>
