Subsequent commits will drop the JS based mouse following focus behavior,
so add appropriate replacement CSS hover styles.
Ref: #6903
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Some devices offer a full LuCI interface from their recovery interface.
As it's read-only it should only be used for installing sysupgrades and
therefore warn users that no settings are saved.
Signed-off-by: Paul Spooren <mail@aparcar.org>
This calls striptags() on the hostname to prevent any XSS over the
hostname. This should fix CVE-2021-33425 as far as I understood it.
If someone adds some Javascript into system.@system[0].hostname it would
have been directly added to the page, this prevents the problem.
This can only be exploited by someone being able to modify the uci
configuration, normally a user with such privileges could also just
modify the webpage.
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
It's been unmaintained for ages and became useless.
Better just limit regular luci-mod-admin to only show basic
functionality in case `ubus call system board` indicates we are running
off initramfs.
Singed-off-by: Daniel Golle <daniel@makrotopia.org>
Remove the reference to setting a password being linked to SSH capability.
(SSH has been initially enabled since year 2015.)
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
If we build multi-themes into firmware, each of them set itself
to be the default theme, what theme should it be?
To make it clear, we only set mediaurlbase if the theme is the
first time to be installed/built-in.
This resolve the issue that theme always change to somewhat default
after upgrading the firmware even with a config-keep-upgrade
Signed-off-by: Chen Minqiang <ptpt52@gmail.com>
The cssmin utility incorrectly breaks up calc() expressions when
minifying rules. Avoid the problem by trimming uneeded spaces.
Fixes: #3801
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
The `data-type` attribute is used to bind datatype validators to a widget
while some templates used the same attribute to denote the name of the
underlying widget.
Change the `data-type` attributes referring to the widget name to
`data-widget` in order to stop the JS token error spam.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Depending on the browser, it is sometimes difficult to scroll if moused
over or after clicking or highlighting text. I often have to click outside
the text to be able to scroll again. The browser perceives that there is
scrolling space/content within the <textarea> element because it is
almost, but not exactly, the same size as its parent <div> element,
when in reality, there is no more text content. This causes scrolling
within the element with a range of just a few pixels, and the rest of
the page remains static.
This is easily solved by adding the "overflow-y" property with value
"hidden". Tested by myself on Chrome 64-bit Windows 10
Signed-off-by: Michael Pratt <mpratt51@gmail.com>
[rewrap commit message, fix Sob syntax]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
- Collapse table borders by default
- Vertically align table cell content
- Inherit font family and size for form widgets
- Fix redundant horizontal padding for cell labels
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Very long values without whitespace can easily overflow the dynlist item
container, so allow the browser to forcibly break such lines.
Reported-by: Hannu Nyman <hannu.nyman@iki.fi>
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
- Add rules for modal dialogs and progress bar widgets
- Increase button and input size on mobile devices
- Convert pt to px units
- Add label and h5 styles
- Add common flash and spin utility classes
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
- Remove 2em min height, this looks out of place with the OpenWrt theme
- Only colorize invalid dropdown when not open
- Drop use of image background for invalid fields while we're at it
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Extend the theme headers to include the translation string scripts,
allowing client side code to translate strings without server side
support.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
This is useful to write page specific CSS rules.
Also fix a missing space in the body CSS class name in the bootstrap theme
while we're at it.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Per the discussion in https://github.com/openwrt/luci/issues/869, make
luci-base sufficient to login, logout, and review and apply or revert
uci changes. This allows most luci-app-xxx to work without having
luci-mod-admin-full installed.
It has been tested with some apps and not luci-mod-admin-full, as well
as with luci-mod-admin-full (to make sure the usual case doesn't break).
Instead of creating a new module namespace (e.g. 'Base') we reduce the
opportunities for breakage by having luci-base take over the 'shell' of
the 'Administration' (admin/....) namespace.
Since admin is assumed by all current building LuCI components (including
Freifunk), this doesn't introduce the 'Administration' tab into any
situation where it would not already be present (but includes it where it
was before).
We also add a "Component not installed" page to avoid fatal errors and
backtrace when e.g. luci-mod-admin-full is not installed.
Signed-off-by: Daniel F. Dickinson <cshored@thecshore.com>
- Use native rpcd uci changes format instead of incompletely converting
back and forth between the old and the new format
- Rework uci changelog template to print the equivalent uci commands
for the various changes
- Rework theme headers to properly count the uncomitted changes
- Rework theme CSS to properly style new changelog
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
This improve applyreboot page and fix problem with luci-nginx that doesn't refresh the page when the router reboot.
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Add support for rendering the "data-description" attribute when rendering
decomposed tables for small screen resolutions.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
