Commit graph

38 commits

Author SHA1 Message Date
Sergey V. Lobanov
13949cb887 luci-theme-openwrt-2020: fix font issue when mixing latin and non-latin symbols
The GalanoGrotesque font used by the openwrt2020 theme does not support non-
latin symbols.

If latin and non-latin symbols are used together in one line it looks strange
because for latin symbols GalanoGrotesque is used but for non-latin symbols a
fallback font is used (sans-serif).

This patch changes default font to Helvetica for the "bg", "ru", "uk", "el"
and "he" locales.

Original patch was written by Jo-Philipp Wich

Fixes: #5580
Signed-off-by: Sergey V. Lobanov <sergey@lobanov.in>
[reword commit message, drop "de" from exception list]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-12-09 17:03:25 +01:00
Paul Spooren
c8d9819c9a themes: warn if booted from initramfs
Some devices offer a full LuCI interface from their recovery interface.
As it's read-only it should only be used for installing sysupgrades and
therefore warn users that no settings are saved.

Signed-off-by: Paul Spooren <mail@aparcar.org>
2021-10-05 15:33:15 -10:00
Petr Štetiar
60fbadfa36 luci-theme-openwrt-2020: add styling of hyperlinks
Currently it's not possible to distinguish between normal text and
hyperlink.

Signed-off-by: Petr Štetiar <ynezz@true.cz>
2021-10-02 23:46:39 -10:00
Petr Štetiar
b5faba1244 luci-theme-openwrt-2020: add styling of abbreviations and acronyms
Style abbreviations and acronyms with dotted underline text-decoration
as without the style it's quite hard to find out which text is
abbreviation or acronym.

References: https://developer.mozilla.org/en-US/docs/Archive/Web_Standards/Styling_Abbreviations_and_Acronyms
Signed-off-by: Petr Štetiar <ynezz@true.cz>
2021-09-28 10:46:36 -10:00
Florian Eckert
a655389032 luci-theme-openwrt-2020: add css success label
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
2021-08-31 08:49:35 +02:00
Jo-Philipp Wich
e0d385e35d
Merge pull request #5253 from selanf/x13 2021-08-11 22:10:56 +02:00
Fritz D. Ansel
b2bea34586 theme openwrt-2020: set maximum menu width
more space for it does not have an advance

Signed-off-by: Fritz D. Ansel <fdansel@yandex.ru>
2021-08-11 09:25:58 +02:00
Fritz D. Ansel
c592ef4f84 theme openwrt-2020: larger bridge-boxes
they are to small for devices like e8450
as it has 4x LAN + 2x WLAN + 1x Bridge

Signed-off-by: Fritz D. Ansel <fdansel@yandex.ru>
2021-08-11 09:25:56 +02:00
Jo-Philipp Wich
e8a6f0bb7c luci-theme-openwrt-2020: fix spinning disk animation
Fixes: #4824
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-17 14:11:39 +02:00
Hauke Mehrtens
5cbd79d7e3 themes: Call striptags() on hostname to prevent XSS
This calls striptags() on the hostname to prevent any XSS over the
hostname. This should fix CVE-2021-33425 as far as I understood it.

If someone adds some Javascript into system.@system[0].hostname it would
have been directly added to the page, this prevents the problem.

This can only be exploited by someone being able to modify the uci
configuration, normally a user with such privileges could also just
modify the webpage.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
2021-06-09 01:33:44 +02:00
Jo-Philipp Wich
064e5cca96
Merge pull request #4985 from j123b567/feature_luci-theme-openwrt-2020_mainmenu-submenu-tweek
luci-theme-openwrt-2020: remove submenu margin-bottom when submenu not visible
2021-06-02 08:21:20 +02:00
Sven Roederer
184e93df5f luci-theme-openwrt-2020: use SVG-file for favicon and logo
Using the scalable graphic in place of the static png file saves some
ressources in flash and network. It also aligns the filetype to the type
announced to the browser.

fixes GitHub-issue #5051

Signed-off-by: Sven Roederer <freifunk@it-solutions.geroedel.de>
2021-05-23 01:54:05 +02:00
Jan Breuer
2b5f78e893 luci-theme-openwrt-2020: remove submenu margin-bottom when submenu not visible
Signed-off-by: Jan Breuer <jan.breuer@jaybee.cz>
2021-04-13 16:45:10 +02:00
Jo-Philipp Wich
c5ff3244e9 luci-theme-openwrt-2020: honor CSS definitions passed by views
Legacy Lua views might declare a global `css` variable to inject custom
styles into the template header. Support this mechanism in the OpenWrt 2020
theme as well.

Ref: https://github.com/openwrt/luci/issues/4972
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-04-09 14:29:12 +02:00
Florian Eckert
e0c0e468e6 luci-theme-openwrt-2020: add missing css success color
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
2021-03-11 12:02:37 +01:00
Jo-Philipp Wich
7057108400 luci-theme-openwrt-2020: rework table styles
Target table, tr, th and td tags directly and stop using the corresponding
CSS class names.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-03-01 19:02:57 +01:00
Jo-Philipp Wich
d3ba6ae3bd Revert "luci-mod-status: allow displaying raw iptables counter values"
This reverts commit 52caa1dc96 since it
contained unrelated changes.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-03-01 19:01:54 +01:00
Jo-Philipp Wich
52caa1dc96 luci-mod-status: allow displaying raw iptables counter values
Fixes: #4852
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-03-01 18:56:27 +01:00
Daniel Golle
4c64aedb3e
luci-mod-failsafe: kill old failsafe mod
It's been unmaintained for ages and became useless.
Better just limit regular luci-mod-admin to only show basic
functionality in case `ubus call system board` indicates we are running
off initramfs.

Singed-off-by: Daniel Golle <daniel@makrotopia.org>
2021-02-24 14:40:10 +00:00
Bryan Forbes
4a00f5bd8e luci-theme-openwrt-2000: Add doctype to header
Fix table rendering in the small responsive breakpoint on Safari (which
ignores `display: block;` for `<td>` elements).

Signed-off-by: Bryan Forbes <bryan@reigndropsfall.net>
2021-02-04 14:47:43 -06:00
Hannu Nyman
258e74c1c3 themes: remove deprecated reference to enabling SSH
Remove the reference to setting a password being linked to SSH capability.
(SSH has been initially enabled since year 2015.)

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2020-08-16 22:19:37 +03:00
Russell Morris
400ecb08f0 luci-theme-openwrt-2020: link hostname to index page
In the Material theme, clicking on the logo takes you to the status page.
This seems logical, and is very helpful. But in OpenWrt 2020, clicking on
the hostname doesn't do anything, so just pulling the same href from Material
so the link works in this theme as well.

Signed-off-by: Russell Morris <rmorris@rkmorris.us>
[adjust subject, commit message]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-06-16 17:09:20 +02:00
Jo-Philipp Wich
97bd192c7e luci-theme-openwrt-2020: add control-group style fixes
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-05-02 23:53:03 +02:00
Jo-Philipp Wich
52486e5862 luci-theme-openwrt-2020: disabled widget style tweaks
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-16 13:30:36 +02:00
Jo-Philipp Wich
a1aa0af102 luci-theme-openwrt-2020: rework menu rendering
Utilize the LuCI.ui.menu class to load, traverse and cache the menu tree
in the local session store.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-16 13:30:35 +02:00
Jo-Philipp Wich
eb8eeb45de luci-theme-openwrt-2020: add styles for disabled input elements
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-14 17:06:34 +02:00
Jo-Philipp Wich
d9bd5466a4 luci-theme-openwrt-2020: remove xhr_poll_status markup
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-14 17:06:34 +02:00
Jo-Philipp Wich
c591490528
Merge pull request #3819 from ptpt52/theme
set mediaurlbase only when it is the first time to be installed
2020-04-08 09:07:55 +02:00
Chen Minqiang
fc150636b9 luci-theme-*: set mediaurlbase if it is the first time to be installed
If we build multi-themes into firmware, each of them set itself
to be the default theme, what theme should it be?

To make it clear, we only set mediaurlbase if the theme is the
first time to be installed/built-in.

This resolve the issue that theme always change to somewhat default
after upgrading the firmware even with a config-keep-upgrade

Signed-off-by: Chen Minqiang <ptpt52@gmail.com>
2020-04-03 21:44:28 +08:00
Jo-Philipp Wich
015712bba0 luci-theme-bootstrap, luci-theme-openwrt-2020: fix dynlist overflows
Fixes: #3795
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-03 13:47:00 +02:00
Jo-Philipp Wich
e2750a4970 luci-theme-openwrt-2020: properly handle invalid checkbox state
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-02 15:34:19 +02:00
Jo-Philipp Wich
5220d4f373 luci-theme-openwrt-2020: fix truncated error badges in tabs
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-01 18:45:18 +02:00
Jo-Philipp Wich
65a461e8a0 luci-theme-openwrt-2020: fix trailing comma in CSS
Since the trailing comma rule is combined with other selectors by CSSmin,
the resulting minified stylesheet has some unexpected margin quirks.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-31 17:05:40 +02:00
Jo-Philipp Wich
ccb7e4a4a7 themes: generalize indicator markup and styling
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-30 17:12:07 +02:00
Jo-Philipp Wich
cfe6771846 luci-theme-openwrt-2020: further layout tweaks
- Properly format mode menu
 - Fadeout of truncated cell labels in mobile layout
 - Limit maximum width of modal overlays

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-29 13:15:31 +02:00
Jo-Philipp Wich
3d3bf40da4 luci-theme-openwrt-2020: fix a number of iPad / iOS 13 quirks
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-28 15:39:39 +01:00
Jo-Philipp Wich
f08cb4f22e luci-theme-openwrt-2020: improve compatibility with luci-theme-bootstrap
- Style input fields without type to treat them like text inputs
 - Style modal overlay as flex column to fix float clearing with adblock 4
 - Add margin to standalone textareas

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-27 19:19:57 +01:00
Jo-Philipp Wich
63b5f63a42 themes: add new theme OpenWrt 2020
Introduce a new theme modelled after the logo guidelines published in
https://openwrt.org/_media/docs/guide-graphic-designer/openwrt-logo-usage-guidelines.pdf

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-26 09:54:40 +01:00