Ensure to return [-1, 0, 1] from the sort callback instead of [0, 1]
which fails in non-FF browsers.
Fixes: #5859
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Do not show the original values for MAC and MTU in device list tooltips
anymore as the values we read from the netdev might already stem from
overridden config settings.
Since there's no generic way to acquire that information, remove the
potentially confusing information.
Fixes: #5820
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
In the worst case, traceroute might take up to 30s to complete when tracing
a completely unreachable path, due to the default limit of 30 hops multiplied
by the per-hop deadline of 1 second (-w 1).
Limit the maximum amount of hops to the configured rpc execution timeout,
20 second by default, in order to avoid running into timed out rpc requests.
Fixes: #5782
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Added code to display fcdn-name in DHCPv4 lease table.
(based on code in DHCPv6 lease table)
Signed-off-by: Max S Kash <asukms@ya.ru>
Indentation adjused and wrapped commit message
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Allow user-specific routing policies to be defined in luci. A single UID
or range of UIDs may be defined.
Signed-off-by: Matthew Hagan <mnhagan88@gmail.com>
The string `<%s>...<%s>` is invalid HTML and will confuse translation software
like poedit as well as human translators. It is not clear that `<%s>...<%s>`
is supposed to interpolate into both a start and end tag and `<%s>` might be
mistaken as a quoted form of `%s` like `«%s»` or `〈%s〉`.
Replace the string with `<a href="%s">...</a>` to make it immediately clear
that the acronym is surrounded by an HTML anchor, only pass the destination
URL via string formatting to avoid mistranslations there.
Fixes: 3bfcf99a68 ("luci-mod-network: fix unbalanced and confusing markup in DHCP translation")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Use the new `firewall.getZoneColorStyle()` helper to apply background
zone color styles to the interface boxes.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
This commit adds support for managing `boot` sections in /etc/config/dhcp.
Signed-off-by: Paul Dee <systemcrash@users.noreply.github.com>
[Hide alias interfaces in network select, reword commit message]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
There is no `type` attribute for `select` elements.
Fixes: 5ac9fd7b3b ("luci-mod-network: diagnostics: remove arp-scan install placeholder")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
We do not want to advertise functionality that is not installed as it may
have been left out intentionally. Referring to "Missing" functionality
is confusing in this case. It is also not comparable to missing protocol
extension hints as those are backed by actual user configuration.
Also replace the freetext input with a dropdown of known network devices
as the hardcoded `br-lan` is not universally applicable to all setups.
In general we want to avoid hardcoding defaults which might deviate from
the system state.
Finaly drop the superfluous width annotations and add a missing space
to the RPC command declaration.
Fixes: 22b7442011 ("luci-mod-admin-full: add arp-scan to network diagnostic")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
This is a JavaScript rewrite of the PR#5152
It adds the ability to perform ARP scans if the tool `arp-scan` is
installed.
Signed-off-by: Paul Spooren <mail@aparcar.org>
"Setup" is a noun, the thing. "Set up" is a verbal idiom, the action.
One cannot setup a DHCP server, just as one cannot fuckup a test, or
ripup some paper. One can, however, set a DHCP server up, and one can
fuck a test up, and rip some paper up.
Signed-off-by: Paul Dee <systemcrash@users.noreply.github.com>
Allow to modify the ipset option in the dhcp.dnsmasq config.
This makes possible to populate IP sets with dnsmasq.
Signed-off-by: Vladislav Grigoryev <vg.aetera@gmail.com>
Allow to modify the sourcefilter option in the network.interface config.
This is required for custom policy routing with IPv6 MWAN and/or NAT6.
Signed-off-by: Vladislav Grigoryev <vg.aetera@gmail.com>
Allow adding routes with unspecified interface.
This is required for prohibit, blackhole and unreachable routes.
Allow adding routes with loopback interface.
This can work as a blackhole route.
Fix netmask to prefix conversion for the routes.
Identify the IP family by the UCI section type.
Avoid setting the routing table textvalue for the rules.
The rules should target none table unless specified otherwise.
Signed-off-by: Vladislav Grigoryev <vg.aetera@gmail.com>
Provide comprehensive routing configuration:
* Rename the "Network > Routes" page to "Network > Routing".
* Unify sorting for the "Status" and "Network" menus.
* Add the tabs "IPv4 Rules" and "IPv6 Rules" to the "Routing" page.
* Provide configuration for IPv4 and IPv6 routing rules.
* Consolidate routing configuration and terminology for IPv4 and IPv6.
Policy-based routing is an increasingly popular problem.
Netifd natively supports policy-based routing:
* Interface-specific options "ip4table" and "ip6table".
* Routing rules using the "rule" and "rule6" sections.
LuCI is missing configuration for routing rules.
Signed-off-by: Vladislav Grigoryev <vg.aetera@gmail.com>
Use proper label text "Unconfigure" for button which "Remove related device settings".
Ref: #5090, #5092
Signed-off-by: Sven Roederer <freifunk@it-solutions.geroedel.de>
Update labels and descriptions for DHCP and DNS settings.
Add missing descriptions and clarify the existing ones.
Group settings by tab and avoid redundant abbreviations.
Consolidate terminology according to the dnsmasq documentation:
https://thekelleys.org.uk/dnsmasq/docs/dnsmasq-man.html
Fix spelling according to the previously adopted policy:
88b9d84388
Signed-off-by: Vladislav Grigoryev <vg.aetera@gmail.com>
The current location for "Network > Hostnames" is confusing.
It is provided by Dnsmasq and partly overlaps with static leases.
Merge "Hostnames" with "Network > DHCP and DNS" as an extra tab.
Also add a simple explanation of the use case.
Signed-off-by: Vladislav Grigoryev <vg.aetera@gmail.com>
[Fix typo in label description string]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
The recently introduced band option support changed the internal frequency
selector choice values, breaking the legacy rates option dependency.
Fixes: #5234
Fixes: 0829d31290 ("luci-mod-network: support newer wireless.wifi-device.band option")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Fix incorrect minimum 60GHz frequency value and ensure that a 60GHz band
choice option is available once corresponding channels are found on the
system.
Ref: http://lists.openwrt.org/pipermail/openwrt-devel/2021-July/035810.html
Suggested-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
