MaxMissed was implemented with positive integers only, whereas I think it should also allow the option of "-1" (disabled state)
Signed-off-by: tew42 <2049715+tew42@users.noreply.github.com>
[slightly edited the proposed text]
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Reorder the CPU utilization classes to be in a more logical order
(from hardware toward user) instead of alphabetical order.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Increase the default number of data items in the RRD database
from 144 to 288. This leads to smaller summarising/averaging periods,
visible especially in the day & week graphs. The averaging intervals
will be: 30s, 5min, 35min, 2h35min, 1d6h30min
(Note: this change only applies in a live router if the RRD database is
empty. E.g after reboot or after emptying the RRD database dir.)
Reference to discussion at #4065
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Adjust the fallback timespan and graph width to the current config
defaults. (The default width in /etc/config/luci_statistics has been
600 already since commit 7ab8b51bd in March 2010.)
Expose the graph height in the config file and
increase it from 100 to 150 to keep the original aspect ratio.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Plugins that provide both detail and non-detail instances led to a mismatch
between the instance list to render and the plugin instance list, causing
tab captions to be wrongly assigned.
Fixes: #5387
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Existing Lua code incorrectly stated that the "Host" option takes a space
sparated list of hostnames which is not the case since the collect plugin
does not handle multiple hosts.
This change reverts the configuration to a simple value as proposed by
the original PR and adjusts the config summary accordingly, while retaining
the translation string.
Ref: https://github.com/openwrt/luci/pull/5010#issuecomment-827285319
Fixes: dd5d96afd ("luci-app-statistics: fix APC UPS host configuration")
Fixes: e7d22dce5 ("luci-app-statistics: convert collectd configuration to client side views")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Ensure that list of hosts is stored as space separated list, like it was
done in the previous Lua implementation.
Fixes: #5010
Fixes: e7d22dce5 ("luci-app-statistics: convert collectd configuration to client side views")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Add initial support for chrony statistics.
At this point introduce time offset and stratum stats.
There is something strange with the host option.
Anything else than 'localhost' or '127.0.0.1' causes an error at
collectd start, even when /tmp/collectd/conf is directly edited
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Shorten the visible delay at the statistics graph endpoint
from 60 seconds to 15 seconds.
The 60s delay was recently added as a way to remove a possible
visible gap at the end of the hourly graph due to absence of
recent data. Default data collection interval is 30s, so that
60s guarantees that there is data upto to the end of the graph.
However, that 60s makes any recent activity to get displayed
really slowly, after a 60-89 second delay.
Shortening the gap to 15s, half of the default data collection
period, should balance things:
* Half of the time there may be a really narrow gap visible and
half of the time there is no gap at all.
* The most recent displayed data point is from 15-44 seconds ago
(instead of 60-89 seconds ago).
Neither 15 or 60 seconds makes any impact to the longer graphs.
To accommodate to possibly shorter timespans, and to avoid the
occasional wrong data series selected for longer period graphs
(see #4065) the endpoint delay might be relative to the timespan.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Add clarifying help text to the RRD time span definition.
Only a few strings are allowed and it is easy to cause uninteded
results especially with minutes as only "min" is for minute while
("m" or "month") are for month.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Adjust the defaults shown in the LuCI user interface to match
the real default values in the default config file.
(If a plugin is disabled and config values get deleted from
the config file, user has been offered incorrect default
values from UI defaults when the plugin is later re-enabled.)
* dns: set br-lan as the interface
* email: socket in /var/run/collectd/ dir
* interface: set br-lan as the interface
* ping: TTL 127, interval 30
* rrdtool: 1hour as shortest period, 144 RRArows
* tcpconns: Do not monitor all, only 22 80
* unixsock: socket in /var/run/collectd/ dir
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Add the dhcpleases plugin:
https://github.com/openwrt/packages/pull/14204
Added-Frontend-by: Hannu Nyman <hannu.nyman@iki.fi>
Signed-off-by: Nick Hainke <vincent@systemli.org>
[Minor changes to graph: alt_autoscale, precision, label]
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
* Add functionality to hide the metric of 'idle' state
from the chart and data table. Many routers are mostly idle,
and the 98% 'idle' dominates the graph reducing its usefulness.
Without 'idle', the smaller CPU usage spikes are visible.
* Hide 'idle' by default. Provide config option to show it.
(note: the option in inside LuCI, and has no impact on actual
data collection by collectd.)
* Tweak the defaults to use the percentage data by default.
It makes more sense to average users than jiffies.
* Set the current LuCI defaults also in the config file.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
It is sometimes useful not to display avg values int the graph.
This option is used to prevent this from appearing in the graph.
In a graph definition this option must be set to *true*,
if the avg values should not be displayed.
```
options = {
gauge = {
title = "Status",
color = "0000ff",
noarea = true,
noavg = true
}
```
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Fixes rendering errors when RRD file names contain IPv6 addresses and the
colon (":") characters are triple escaped.
Adapts the Lua-specific fix in #4340 to Javascript.
Signed-off-by: Philip L. McMahon <philip.l.mcmahon@gmail.com>
Apparently " in a comment may cause an error in some conditions.
Reference to issue #4020
Remove also ";" just in case...
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Add graphs for sqm data collected by 'sqm_collect.sh'
An overall sqm graph displays bandwidth (Kb/s), Backlog (Bytes) and
drops for each supported qdisc.
Sqm-cake supports cake's tin structure and displays many(!) graphs per
tin:
Bandwidth: Bandwidth (Kb/s), bandwidth threshold (Kb/s).
Latency: Target latency, Peak, Average, Sparse flow latency
Backlog v Drops: Backlog (Bytes), Drops, ECN marks, Ack-filter drops
Flow counts: Sparse flows, Bulk flows, Unresponsive flows
Fun for all the family :-)
Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
The existing graph shows a conntrack entry usage value but doesn't show
a conntrack table size figure so you don't know if you're close to
filling the table. Add a percent usage graph to show conntrack table
percent used.
Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
- Add a per-plugin overview tab that contains the (non-detail) graphs of
each plugin instance, similar to the old Lua based implementation
- Numerically order plugin instances starting with numbers
- Avoid multiple renderings of the same graphs
- Fix legend of tcpconns graphs
- Move cpufreq distribution and transition charts to detail tabs
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
- Remove redundant form flags
- Fix various default values
- Add some new collect options and remove options that do not exist anymore
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
