Commit graph

577 commits

Author SHA1 Message Date
Florian Eckert
678ee038c0 luci-theme-openwrt-2020: add css success label
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
(cherry picked from commit a655389032)
2021-08-31 08:52:10 +02:00
Jo-Philipp Wich
ecc58e7fcb luci-theme-openwrt-2020: fix spinning disk animation
Fixes: #4824
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit e8a6f0bb7c)
2021-06-21 12:06:44 +02:00
Jo-Philipp Wich
bd36169e8c luci-theme-bootstrap: mobile style fixes for vlan filter matrix
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit e6a2cdbdab)
2021-06-13 21:50:18 +02:00
Jo-Philipp Wich
2afd4b78c8 luci-theme-openwrt-2020: rework table styles
Target table, tr, th and td tags directly and stop using the corresponding
CSS class names.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 7057108400)
2021-06-12 20:01:58 +02:00
Jo-Philipp Wich
1818ddcac3 luci-theme-bootstrap: add svg help icon to form field descriptions
The still referenced help.gif icon is absent by default since it has been
moved to luci-compat.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 6960819997)
2021-06-12 19:23:01 +02:00
Sven Roederer
904fb39c31 luci-theme-openwrt-2020: use SVG-file for favicon and logo
Using the scalable graphic in place of the static png file saves some
ressources in flash and network. It also aligns the filetype to the type
announced to the browser.

fixes GitHub-issue #5051

Signed-off-by: Sven Roederer <freifunk@it-solutions.geroedel.de>
(cherry picked from commit 184e93df5f)
2021-06-12 19:22:37 +02:00
Jan Breuer
87daaa24c8 luci-theme-openwrt-2020: remove submenu margin-bottom when submenu not visible
Signed-off-by: Jan Breuer <jan.breuer@jaybee.cz>
(cherry picked from commit 2b5f78e893)
2021-06-12 19:21:24 +02:00
Hauke Mehrtens
139edfce8b themes: Call striptags() on hostname to prevent XSS
This calls striptags() on the hostname to prevent any XSS over the
hostname. This should fix CVE-2021-33425 as far as I understood it.

If someone adds some Javascript into system.@system[0].hostname it would
have been directly added to the page, this prevents the problem.

This can only be exploited by someone being able to modify the uci
configuration, normally a user with such privileges could also just
modify the webpage.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
(cherry picked from commit 5cbd79d7e3)
2021-06-09 20:53:15 +02:00
Liangbin Lian
ac0bcc2d10 luci-theme-material: fix wrong active state on common prefix node
Before fixed, if we have two nodes: 'services/ddns' and 'services/ddnsto',
click any one of they, will show they all actived.

Signed-off-by: Liangbin Lian <jjm2473@gmail.com>
(cherry picked from commit 97d50d2c6b)
2021-05-26 10:09:05 +03:00
Jo-Philipp Wich
6137c9ff33 luci-theme-openwrt-2020: honor CSS definitions passed by views
Legacy Lua views might declare a global `css` variable to inject custom
styles into the template header. Support this mechanism in the OpenWrt 2020
theme as well.

Ref: https://github.com/openwrt/luci/issues/4972
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit c5ff3244e9)
2021-04-09 14:31:06 +02:00
Florian Eckert
4c6fb6bb97 luci-theme-openwrt-2020: add missing css success color
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
(cherry picked from commit e0c0e468e6)
2021-03-12 15:03:02 +01:00
Bryan Forbes
4a00f5bd8e luci-theme-openwrt-2000: Add doctype to header
Fix table rendering in the small responsive breakpoint on Safari (which
ignores `display: block;` for `<td>` elements).

Signed-off-by: Bryan Forbes <bryan@reigndropsfall.net>
2021-02-04 14:47:43 -06:00
Hannu Nyman
db15e3f695 luci-theme-rosy: Remove BROKEN theme
The Rosy theme has been marked broken for over a year,
since 23 Dec 2019. Remove it now, so that it does not
get into the next release branch 20.xx (or 21.xx).

Reference to
https://github.com/openwrt/luci/issues/3759#issuecomment-599436159

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2020-12-29 14:23:13 +02:00
Dirk Brenken
6ffd1592ce luci-theme-bootstrap: fix text wrapping in buttons
* should fix #4647

Signed-off-by: Dirk Brenken <dev@brenken.org>
2020-12-27 23:02:50 -10:00
Ansuel Smith
01cefed7f0
luci-theme-material: fix bigger button for combo-box
Combobox are bigger than any other button. Align the dimension to all the other buttons.

Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
2020-10-30 21:34:10 +01:00
Oldřich Jedlička
b03a508c6c luci-theme-material: Fix section title padding.
After moving section title from `legend`, which was translated to `span`
with style `panel-title`, to `h3`, update also CSS style to match first
`h3` in `cbi-section`.

Signed-off-by: Oldřich Jedlička <oldium.pro@gmail.com>
2020-10-25 12:11:24 +01:00
Hannu Nyman
258e74c1c3 themes: remove deprecated reference to enabling SSH
Remove the reference to setting a password being linked to SSH capability.
(SSH has been initially enabled since year 2015.)

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2020-08-16 22:19:37 +03:00
Russell Morris
400ecb08f0 luci-theme-openwrt-2020: link hostname to index page
In the Material theme, clicking on the logo takes you to the status page.
This seems logical, and is very helpful. But in OpenWrt 2020, clicking on
the hostname doesn't do anything, so just pulling the same href from Material
so the link works in this theme as well.

Signed-off-by: Russell Morris <rmorris@rkmorris.us>
[adjust subject, commit message]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-06-16 17:09:20 +02:00
Russell Morris
27fc7a8b4e luci-theme-bootstrap: update href for Bootstrap "brand"
In the Material theme, clicking on the logo takes you to the status page.
This seems logical, and is very helpful. But in Bootstrap, it doesn't
do anything, so just pulling the same href from Material to Bootstrap,
so the link works in Bootstrap as well.

Signed-off-by: Russell Morris <rmorris@rkmorris.us>
[adjust commit subject, squash commits]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-06-16 17:09:19 +02:00
Florian Eckert
aef19bb2ef luci-theme-rosy: fix Makefile file mod
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
2020-05-04 12:44:03 +02:00
Florian Eckert
0024609a00 luci-theme-material: fix Makefile file mod
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
2020-05-04 12:44:03 +02:00
Florian Eckert
1b875a610f luci-theme-material: remove useless logging output
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
2020-05-04 12:43:59 +02:00
Jo-Philipp Wich
97bd192c7e luci-theme-openwrt-2020: add control-group style fixes
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-05-02 23:53:03 +02:00
Jo-Philipp Wich
52486e5862 luci-theme-openwrt-2020: disabled widget style tweaks
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-16 13:30:36 +02:00
Jo-Philipp Wich
1ac8df2614 luci-theme-bootstrap: rework menu rendering
Utilize the LuCI.ui.menu class to load, traverse and cache the menu tree
in the local session store.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-16 13:30:35 +02:00
Jo-Philipp Wich
48269ade61 luci-theme-openwrt: rework menu rendering
Utilize the LuCI.ui.menu class to load, traverse and cache the menu tree
in the local session store.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-16 13:30:35 +02:00
Jo-Philipp Wich
a1aa0af102 luci-theme-openwrt-2020: rework menu rendering
Utilize the LuCI.ui.menu class to load, traverse and cache the menu tree
in the local session store.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-16 13:30:35 +02:00
Jo-Philipp Wich
eb8eeb45de luci-theme-openwrt-2020: add styles for disabled input elements
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-14 17:06:34 +02:00
Jo-Philipp Wich
d9bd5466a4 luci-theme-openwrt-2020: remove xhr_poll_status markup
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-14 17:06:34 +02:00
Jo-Philipp Wich
c591490528
Merge pull request #3819 from ptpt52/theme
set mediaurlbase only when it is the first time to be installed
2020-04-08 09:07:55 +02:00
Chen Minqiang
fc150636b9 luci-theme-*: set mediaurlbase if it is the first time to be installed
If we build multi-themes into firmware, each of them set itself
to be the default theme, what theme should it be?

To make it clear, we only set mediaurlbase if the theme is the
first time to be installed/built-in.

This resolve the issue that theme always change to somewhat default
after upgrading the firmware even with a config-keep-upgrade

Signed-off-by: Chen Minqiang <ptpt52@gmail.com>
2020-04-03 21:44:28 +08:00
Jo-Philipp Wich
015712bba0 luci-theme-bootstrap, luci-theme-openwrt-2020: fix dynlist overflows
Fixes: #3795
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-03 13:47:00 +02:00
Jo-Philipp Wich
e2750a4970 luci-theme-openwrt-2020: properly handle invalid checkbox state
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-02 15:34:19 +02:00
Jo-Philipp Wich
5220d4f373 luci-theme-openwrt-2020: fix truncated error badges in tabs
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-01 18:45:18 +02:00
Jo-Philipp Wich
65a461e8a0 luci-theme-openwrt-2020: fix trailing comma in CSS
Since the trailing comma rule is combined with other selectors by CSSmin,
the resulting minified stylesheet has some unexpected margin quirks.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-31 17:05:40 +02:00
Jo-Philipp Wich
63057a08dc luci-theme-openwrt: work around cssmin bug breaking the minified CSS.
The cssmin utility incorrectly breaks up calc() expressions when
minifying rules. Avoid the problem by trimming uneeded spaces.

Fixes: #3801
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-31 15:27:13 +02:00
Jo-Philipp Wich
ccb7e4a4a7 themes: generalize indicator markup and styling
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-30 17:12:07 +02:00
Jo-Philipp Wich
cfe6771846 luci-theme-openwrt-2020: further layout tweaks
- Properly format mode menu
 - Fadeout of truncated cell labels in mobile layout
 - Limit maximum width of modal overlays

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-29 13:15:31 +02:00
Jo-Philipp Wich
3d3bf40da4 luci-theme-openwrt-2020: fix a number of iPad / iOS 13 quirks
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-28 15:39:39 +01:00
Jo-Philipp Wich
f08cb4f22e luci-theme-openwrt-2020: improve compatibility with luci-theme-bootstrap
- Style input fields without type to treat them like text inputs
 - Style modal overlay as flex column to fix float clearing with adblock 4
 - Add margin to standalone textareas

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-27 19:19:57 +01:00
Jo-Philipp Wich
c99684dff7 luci-theme-bootstrap: dynamically adjust body margin
Fixes: #3722
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-27 17:58:12 +01:00
Jo-Philipp Wich
63b5f63a42 themes: add new theme OpenWrt 2020
Introduce a new theme modelled after the logo guidelines published in
https://openwrt.org/_media/docs/guide-graphic-designer/openwrt-logo-usage-guidelines.pdf

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-26 09:54:40 +01:00
Jo-Philipp Wich
ca17ec9b4f luci-theme-bootstrap: fixup assoclist styling
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 3b40c582baefcb302fb23ed633ed85ab1ac72a9e)
2020-03-24 22:14:18 +01:00
Jo-Philipp Wich
5d7dc391d4 themes: ensure that data-page attribute is escaped
Fixes: #3757
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-15 17:48:40 +01:00
Jo-Philipp Wich
aa2445cdd8 luci-theme-bootstrap: fix overview wireless display quirks
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-04 09:29:07 +01:00
Jo-Philipp Wich
0130e2b08c themes: render menu even when not logged in
Ref: #3563
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-01-25 23:28:24 +01:00
Florian Eckert
71743a7ef6 luci-theme-material: fix button position on modal save
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
2020-01-21 09:21:55 +01:00
Florian Eckert
1c49bda198 luci-theme-material: fix apply dropdown color
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
2020-01-20 14:11:53 +01:00
Jo-Philipp Wich
0d97ea26f8 luci-theme-bootstrap: add CSS fixes for tooltip elements
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-01-19 17:50:37 +01:00
Jo-Philipp Wich
3c5feae57c luci-theme-bootstrap: fix invalid dropdown state styling
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-01-15 18:54:32 +01:00