The OpenVPN file view uses a dummy Map() instance to render the breadcrumb
template which triggers a uci permission error since the view is being
rendered by a form() action which does not set up the expected permission
flags. CBI Map() instances should only be used for cbi() dispatch targets.
Solve the issue by appending the breadcrumb template directly to the
SimpleForm() instance and by removing the redundant dummy Map() instance.
Fixes: #4370
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Update the list of selectable TLS cipher suites.
The previous list consisted mostly of unsupported ciphers and the IANA
names should be used.
Signed-off-by: Martin Schiller <ms@dev.tdt.de>
* parse special 'remote' syntax (remote <host> <port> <proto> as well
(removed in last commit by accident)
Signed-off-by: Dirk Brenken <dev@brenken.org>
Translation of page titles in the advanced configuration mode is done
in such a way that the strings to be translated are not visible for
'i18n-scan.pl' script. This commit fixes this and makes page titles
visible for the 'i18n-scan.pl'.
Signed-off-by: Anton Kikin <a.kikin@tano-systems.com>
This option is not a flag.
Signed-off-by: Jose Riha <jose1711@gmail.com>
[Changed commit message and add missing Singed-off-by]
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
* re-add config option comp_lzo according to
openwrt/openwrt@3850b41
* re-add config option comp_noadapt. This has never been removed
from openwrt
Signed-off-by: Martin Schiller <ms@dev.tdt.de>
If a new instance is edit then all boolean option are shown on the LuCI.
This is confusing. To fix this hide all boolean ellements on the config
page which are not enabled by default. They must be add first.
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
This change will redirect on apply/save to the OpenVPN overview page.
This is the default behaviour on LuCI.
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
* fix possible exception in template based ovpn creation
* remove needless shellquote function in controller,
the filename will be checked on client side with JS
* enhance FileUpload behaviour in basic/advanced mode:
- change "auth_user_pass" to FileUpload
- cfg entries (even with default values) will be shown
- existing entries are now removable (incl. file unlink),
simply clear the appropriate textbox
* change "key_direction" option to boolean ListValue
* add "config" option to basic/advanced edit,
to make it possible to change the upload path in LuCI
Signed-off-by: Dirk Brenken <dev@brenken.org>
* add the ability to upload ovpn files directly,
incl. appropriate uci entry in openvpn config
* add the ability to edit ovpn files directly ('file' mode),
beside the 'basic' and 'advanced' modes for normal setups
* client side checks to validate instance name & template selection,
incl. online error reporting
* automatically remove non-ascii characters & windows line endings
from transfered ovpn file
* change from after_commit to after_apply hook
* remove misleading default values for Port & Protocol in Overview
Signed-off-by: Dirk Brenken <dev@brenken.org>
* remove obsolete config options according to
openwrt/openwrt@89b8ba9, fix for #2135
* whitespace/intendation fixes
* replace fieldset leftover with div
* fix finally recipe options transfer to regular config with "Add"
Signed-off-by: Dirk Brenken <dev@brenken.org>
Closes#628 as suggestion was implemented and tested.
Added PID handling function (Fixes https://dev.openwrt.org/ticket/21506).
Signed-off-by: Vladimir Ulrich <admin@evl.su>
