From d7be4983cf8f3d03fbf335e5e135392726b93a24 Mon Sep 17 00:00:00 2001 From: Olli Asikainen Date: Wed, 30 Jun 2021 02:03:00 +0300 Subject: [PATCH] luci-base: batch DOM updates to prevent slowdown Signed-off-by: Olli Asikainen (cherry picked from commit f919635310286b3b905aedb716d707da1ea2c811) --- .../luci-base/htdocs/luci-static/resources/cbi.js | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/modules/luci-base/htdocs/luci-static/resources/cbi.js b/modules/luci-base/htdocs/luci-static/resources/cbi.js index 22cbecc864..2fc2f09632 100644 --- a/modules/luci-base/htdocs/luci-static/resources/cbi.js +++ b/modules/luci-base/htdocs/luci-static/resources/cbi.js @@ -752,7 +752,7 @@ function cbi_update_table(table, data, placeholder) { }); if (Array.isArray(data)) { - var n = 0, rows = target.querySelectorAll('tr, .tr'); + var n = 0, rows = target.querySelectorAll('tr, .tr'), trows = []; data.forEach(function(row) { var trow = E('tr', { 'class': 'tr' }); @@ -770,12 +770,16 @@ function cbi_update_table(table, data, placeholder) { trow.classList.add('cbi-rowstyle-%d'.format((n++ % 2) ? 2 : 1)); - if (rows[n]) - target.replaceChild(trow, rows[n]); - else - target.appendChild(trow); + trows[n] = trow; }); + for (var i = 1; i < n; i++) { + if (rows[i]) + target.replaceChild(trows[i], rows[i]); + else + target.appendChild(trows[i]); + } + while (rows[++n]) target.removeChild(rows[n]);