Difuse/luci
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

luci-app-ddns: check existence of nslookup util rather than making DNS request

Browse source 
This saves a DNS request whenever the check is performed.  For systems with nameservers configured in `/etc/resolv.conf`, nslookup will sent a request to those servers (eg bypassing /etc/hosts), thus taking a lot more time than necessary.  For servers that are remote, this will take a *lot* longer than just checking if the nslookup util exists.

This change follows in the same vein as all the other checks and just using `which` without actually invoking the util's functionality.

Signed-off-by: David Beitey <david@davidjb.com>
This commit is contained in:
David Beitey 2018-12-21 02:51:56 +00:00
parent 49c558a693
commit cfe4ae1668
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
applications/luci-app-ddns/luasrc/tools/ddns.lua
View file

@ -103,7 +103,7 @@ function env_info(type)
end end
local function has_nslookup() local function has_nslookup()
return (SYS.call( [[$(which nslookup) localhost 2>&1 | grep -qF "(null)"]] ) ~= 0) return (SYS.call( [[which nslookup >/dev/null 2>&1]] ) == 0)
end end
if type == "has_bindhost" then if type == "has_bindhost" then