Difuse/luci
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #4538 from oldium/fix-titles

Browse source 
luci-base/luci-compat: Replace legend element with h3.
This commit is contained in:
Jo-Philipp Wich 2020-10-30 21:09:19 +01:00 committed by GitHub
commit ca86f8d09e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/luci-base/htdocs/luci-static/resources/form.js
View file

@ -2219,7 +2219,7 @@ var CBITypedSection = CBIAbstractSection.extend(/** @lends LuCI.form.TypedSectio
});
if (this.title != null && this.title != '')
sectionEl.appendChild(E('legend', {}, this.title));
sectionEl.appendChild(E('h3', {}, this.title));
if (this.description != null && this.description != '')
sectionEl.appendChild(E('div', { 'class': 'cbi-section-descr' }, this.description));
@ -3138,7 +3138,7 @@ var CBINamedSection = CBIAbstractSection.extend(/** @lends LuCI.form.NamedSectio
});
if (typeof(this.title) === 'string' && this.title !== '')
sectionEl.appendChild(E('legend', {}, this.title));
sectionEl.appendChild(E('h3', {}, this.title));
if (typeof(this.description) === 'string' && this.description !== '')
sectionEl.appendChild(E('div', { 'class': 'cbi-section-descr' }, this.description));

4
modules/luci-compat/luasrc/view/cbi/nsection.htm
View file

@ -1,7 +1,7 @@
<% if self:cfgvalue(self.section) then section = self.section %>
<div class="cbi-section">
<% if self.title and #self.title > 0 then -%>
<legend><%=self.title%></legend>
<h3><%=self.title%></h3>
<%- end %>
<% if self.description and #self.description > 0 then -%>
<div class="cbi-section-descr"><%=self.description%></div>
@ -19,7 +19,7 @@
<% if self.template_addremove then include(self.template_addremove) else -%>
<div class="cbi-section" id="cbi-<%=self.config%>-<%=self.section%>">
<% if self.title and #self.title > 0 then -%>
<legend><%=self.title%></legend>
<h3><%=self.title%></h3>
<%- end %>
<div class="cbi-section-descr"><%=self.description%></div>
<input type="submit" class="btn cbi-button cbi-button-add" name="cbi.cns.<%=self.config%>.<%=self.section%>" value="<%:Add%>" />

2
modules/luci-compat/luasrc/view/cbi/nullsection.htm
View file

@ -1,6 +1,6 @@
<div class="cbi-section">
<% if self.title and #self.title > 0 then -%>
<legend><%=self.title%></legend>
<h3><%=self.title%></h3>
<%- end %>
<% if self.description and #self.description > 0 then -%>
<div class="cbi-section-descr"><%=self.description%></div>

2
modules/luci-compat/luasrc/view/cbi/tsection.htm
View file

@ -1,6 +1,6 @@
<div class="cbi-section" id="cbi-<%=self.config%>-<%=self.sectiontype%>">
<% if self.title and #self.title > 0 then -%>
<legend><%=self.title%></legend>
<h3><%=self.title%></h3>
<%- end %>
<% if self.error_msg and #self.error_msg > 0 then -%>
<div class="cbi-section-error">

3
themes/luci-theme-material/htdocs/luci-static/material/cascade.css
View file

@ -754,7 +754,6 @@ fieldset > fieldset,
border-bottom: thin solid #eee;
}
.cbi-section > h3:first-child,
.cbi-section > h4:first-child,
.cbi-section > p:first-child,
[data-tab-title] > h3:first-child,
@ -2547,6 +2546,7 @@ input[name="nslookup"] {
padding: .2rem .5rem;
}
.cbi-section > h3:first-child,
.panel-title {
font-size: 1.1rem;
padding-bottom: 1rem;
@ -2951,6 +2951,7 @@ input[name="nslookup"] {
display: none;
}
.cbi-section > h3:first-child,
.panel-title {
font-size: 1.4rem;
padding-bottom: 1rem;