luci-app-dockerman: cbi/images update coding style

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

applications/luci-app-dockerman/luasrc/model/cbi/dockerman/images.lua

@@ -8,23 +8,41 @@ local uci = luci.model.uci.cursor()
 local docker = require "luci.model.docker"
 local dk = docker.new()
 
-local containers, images
+local containers, images, res
-local res = dk.images:list()
+
-if res.code <300 then images = res.body else return end
+res = dk.images:list()
-res = dk.containers:list({query = {all=true}})
+if res.code < 300 then
-if res.code <300 then containers = res.body else return end
+	images = res.body
+else
+	return
+end
+
+res = dk.containers:list({
+	query = {
+		all=true
+	}
+})
+if res.code < 300 then
+	containers = res.body
+else
+	return
+end
 
 function get_images()
 	local data = {}
+
 	for i, v in ipairs(images) do
 		local index = v.Created .. v.Id
+
 		data[index]={}
 		data[index]["_selected"] = 0
 		data[index]["id"] = v.Id:sub(8)
 		data[index]["_id"] = '<a href="javascript:new_tag(\''..v.Id:sub(8,20)..'\')" class="dockerman-link" title="'..translate("New tag")..'">' .. v.Id:sub(8,20) .. '</a>'
+
 		if v.RepoTags and next(v.RepoTags)~=nil then
 			for i, v1 in ipairs(v.RepoTags) do
 				data[index]["_tags"] =(data[index]["_tags"] and ( data[index]["_tags"] .. "<br>" )or "") .. ((v1:match("<none>") or (#v.RepoTags == 1)) and v1 or ('<a href="javascript:un_tag(\''..v1..'\')" class="dockerman_link" title="'..translate("Remove tag")..'" >' .. v1 .. '</a>'))
+
 				if not data[index]["tag"] then
 					data[index]["tag"] = v1--:match("<none>") and nil or v1
 				end
@@ -33,23 +51,24 @@ function get_images()
 			data[index]["_tags"] = v.RepoDigests[1] and v.RepoDigests[1]:match("^(.-)@.+")
 			data[index]["_tags"] = (data[index]["_tags"] and data[index]["_tags"] or  "<none>" ).. ":<none>"
 		end
+
 		data[index]["_tags"] = data[index]["_tags"]:gsub("<none>","&lt;none&gt;")
-    -- data[index]["_tags"] = '<a href="javascript:handle_tag(\''..data[index]["_id"]..'\')">' .. data[index]["_tags"] .. '</a>'
 		for ci,cv in ipairs(containers) do
 			if v.Id == cv.ImageID then
 				data[index]["_containers"] = (data[index]["_containers"] and (data[index]["_containers"] .. " | ") or "")..
 				'<a href='..luci.dispatcher.build_url("admin/docker/container/"..cv.Id)..' class="dockerman_link" title="'..translate("Container detail")..'">'.. cv.Names[1]:sub(2).."</a>"
 			end
 		end
+
 		data[index]["_size"] = string.format("%.2f", tostring(v.Size/1024/1024)).."MB"
 		data[index]["_created"] = os.date("%Y/%m/%d %H:%M:%S",v.Created)
 	end
+
 	return data
 end
 
 local image_list = get_images()
 
--- m = Map("docker", translate("Docker"))
 m = SimpleForm("docker", translate("Docker"))
 m.submit=false
 m.reset=false
@@ -66,6 +85,7 @@ action_pull.template = "dockerman/cbi/inlinebutton"
 action_pull.inputstyle = "add"
 tag_name.write = function(self, section, value)
 	local hastag = value:find(":")
+
 	if not hastag then
 		value = value .. ":latest"
 	end
@@ -74,11 +94,11 @@ end
 action_pull.write = function(self, section)
 	local tag = pull_value["_image_tag_name"]
 	local json_stringify = luci.jsonc and luci.jsonc.stringify
+
 	if tag and tag ~= "" then
 		docker:write_status("Images: " .. "pulling" .. " " .. tag .. "...\n")
-    -- local x_auth = nixio.bin.b64encode(json_stringify({serveraddress= server})) , header={["X-Registry-Auth"] = x_auth}
 		local res = dk.images:create({query = {fromImage=tag}}, docker.pull_image_show_status_cb)
-    -- {"errorDetail": {"message": "failed to register layer: ApplyLayer exit status 1 stdout:  stderr: write \/docker: no space left on device" }, "error": "failed to register layer: ApplyLayer exit status 1 stdout:  stderr: write \/docker: no space left on device" }
+
 		if res and res.code == 200 and (res.body[#res.body] and not res.body[#res.body].error and res.body[#res.body].status and (res.body[#res.body].status == "Status: Downloaded newer image for ".. tag)) then
 			docker:clear_status()
 		else
@@ -87,6 +107,7 @@ action_pull.write = function(self, section)
 	else
 		docker:append_status("code: 400 please input the name of image name!")
 	end
+
 	luci.http.redirect(luci.dispatcher.build_url("admin/docker/images"))
 end
 
@@ -95,39 +116,44 @@ local im = import_section:option(DummyValue, "_image_import")
 im.template = "dockerman/images_import"
 
 local image_table = m:section(Table, image_list, translate("Images"))
+image_table:option(DummyValue, "_tags", translate("RepoTags")).rawhtml = true
+image_table:option(DummyValue, "_containers", translate("Containers")).rawhtml = true
+image_table:option(DummyValue, "_size", translate("Size"))
+image_table:option(DummyValue, "_created", translate("Created"))
 
 local image_selecter = image_table:option(Flag, "_selected","")
 image_selecter.disabled = 0
 image_selecter.enabled = 1
 image_selecter.default = 0
-
-local image_id = image_table:option(DummyValue, "_id", translate("ID"))
-image_id.rawhtml = true
-image_table:option(DummyValue, "_tags", translate("RepoTags")).rawhtml = true
-image_table:option(DummyValue, "_containers", translate("Containers")).rawhtml = true
-image_table:option(DummyValue, "_size", translate("Size"))
-image_table:option(DummyValue, "_created", translate("Created"))
 image_selecter.write = function(self, section, value)
 	image_list[section]._selected = value
 end
 
+local image_id = image_table:option(DummyValue, "_id", translate("ID"))
+image_id.rawhtml = true
+
 local remove_action = function(force)
 	local image_selected = {}
-  -- 遍历table中sectionid
+
 	local image_table_sids = image_table:cfgsections()
 	for _, image_table_sid in ipairs(image_table_sids) do
-    -- 得到选中项的名字
 		if image_list[image_table_sid]._selected == 1 then
 			image_selected[#image_selected+1] = (image_list[image_table_sid]["_tags"]:match("<br>") or image_list[image_table_sid]["_tags"]:match("&lt;none&gt;")) and image_list[image_table_sid].id or image_list[image_table_sid].tag
 		end
 	end
+
 	if next(image_selected) ~= nil then
 		local success = true
+
 		docker:clear_status()
 		for _,img in ipairs(image_selected) do
-      docker:append_status("Images: " .. "remove" .. " " .. img .. "...")
 			local query
-      if force then query = {force = true} end
+			docker:append_status("Images: " .. "remove" .. " " .. img .. "...")
+
+			if force then
+				query = {force = true}
+			end
+
 			local msg = dk.images:remove({id = img, query = query})
 			if msg.code ~= 200 then
 				docker:append_status("code:" .. msg.code.." ".. (msg.body.message and msg.body.message or msg.message).. "\n")
@@ -136,7 +162,11 @@ local remove_action = function(force)
 				docker:append_status("done\n")
 			end
 		end
-    if success then docker:clear_status() end
+
+		if success then
+			docker:clear_status()
+		end
+
 		luci.http.redirect(luci.dispatcher.build_url("admin/docker/images"))
 	end
 end
@@ -145,7 +175,9 @@ local docker_status = m:section(SimpleSection)
 docker_status.template = "dockerman/apply_widget"
 docker_status.err = docker:read_status()
 docker_status.err = docker_status.err and docker_status.err:gsub("\n","<br>"):gsub(" ","&nbsp;")
-if docker_status.err then docker:clear_status() end
+if docker_status.err then
+	docker:clear_status()
+end
 
 local action = m:section(Table,{{}})
 action.notitle=true
@@ -177,18 +209,21 @@ btnsave.inputstyle = "edit"
 btnsave.forcewrite = true
 btnsave.write = function (self, section)
 	local image_selected = {}
+
 	local image_table_sids = image_table:cfgsections()
 	for _, image_table_sid in ipairs(image_table_sids) do
 		if image_list[image_table_sid]._selected == 1 then
 			image_selected[#image_selected+1] = image_list[image_table_sid].id --image_id:cfgvalue(image_table_sid)
 		end
 	end
+
 	if next(image_selected) ~= nil then
-    local names
+		local names, first
+
 		for _,img in ipairs(image_selected) do
 			names = names and (names .. "&names=".. img) or img
 		end
-    local first
+
 		local cb = function(res, chunk)
 			if res.code == 200 then
 				if not first then
@@ -205,8 +240,10 @@ btnsave.write = function (self, section)
 				luci.ltn12.pump.all(chunk, luci.http.write)
 			end
 		end
+
 		docker:write_status("Images: " .. "save" .. " " .. table.concat(image_selected, "\n") .. "...")
 		local msg = dk.images:get({query = {names = names}}, cb)
+
 		if msg.code ~= 200 then
 			docker:append_status("code:" .. msg.code.." ".. (msg.body.message and msg.body.message or msg.message).. "\n")
 			success = false
@@ -220,4 +257,5 @@ local btnload = action:option(Button, "load")
 btnload.inputtitle= translate("Load")
 btnload.template = "dockerman/images_load"
 btnload.inputstyle = "add"
+
 return m