Difuse/luci
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

luci-base: firewall.js: don't treat zone name as network fallback

Browse source 
Drop obsolete extra logic which treats the zone name as covered network
name in case the network list is unset. This behaviour applied to the
pre-fw3 uci firewall, but is not supported since fw3 anymore.

Ref: https://forum.openwrt.org/t/luci-zone-creation-bug/55921
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 4052436d82)
This commit is contained in:
Jo-Philipp Wich 2020-03-02 10:08:32 +01:00
parent 70b5982b4c
commit b01cf69536
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/luci-base/htdocs/luci-static/resources/firewall.js
View file

@ -362,13 +362,13 @@ Zone = AbstractFirewallItem.extend({
if (newNetworks.length > 0)
this.set('network', newNetworks.join(' '));
else
this.set('network', ' ');
this.set('network', null);
return (newNetworks.length < oldNetworks.length);
},
getNetworks: function() {
return L.toArray(this.get('network') || this.get('name'));
return L.toArray(this.get('network'));
},
clearNetworks: function() {