Difuse/luci
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

luci-base: ui.js: resolve parent ul early in UIDropdown.toggleItem()

Browse source 
The parent node of the current li might be null after collapsing the
dropdown, so resolve the parent ul early to avoid passing null to
subsequent calls.

Fixes clearing custom input values in DynamicList dropdowns.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit b8d2bcd432)
This commit is contained in:
Jo-Philipp Wich 2021-02-19 10:39:00 +01:00
parent d55158730e
commit af4c851d35
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/luci-base/htdocs/luci-static/resources/ui.js
View file

@ -1360,6 +1360,8 @@ var UIDropdown = UIElement.extend(/** @lends LuCI.ui.Dropdown.prototype */ {
/** @private */ /** @private */
toggleItem: function(sb, li, force_state) { toggleItem: function(sb, li, force_state) {
var ul = li.parentNode;
if (li.hasAttribute('unselectable')) if (li.hasAttribute('unselectable'))
return; return;
@ -1436,7 +1438,7 @@ var UIDropdown = UIElement.extend(/** @lends LuCI.ui.Dropdown.prototype */ {
this.closeDropdown(sb, true); this.closeDropdown(sb, true);
} }
this.saveValues(sb, li.parentNode); this.saveValues(sb, ul);
}, },
/** @private */ /** @private */