Difuse/luci
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

luci-mod-network: use createHanleFn for handleJoin function

Browse source 
handleJoin can be slow to parse all the data and show the new modal, this can result in the disappear of the scan modal and the showing of the wifi config page while the data are generating. This is wrong since a user can think that he did something wrong. Fix this by using the createHandleFn and by removing the scan pool function instead of calling ScanAbort function that with the other thing wrongly removes the Scan modal. (the modal is replaced with the add one when all the data are ready)

Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
This commit is contained in:
Ansuel Smith 2020-11-01 01:45:41 +01:00
parent 1da9df8376
commit ae47a5104d
No known key found for this signature in database
GPG key ID: AC001D09ADBFEAD7
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/luci-mod-network/htdocs/luci-static/resources/view/network/wireless.js
View file

@ -1742,7 +1742,7 @@ return view.extend({
E('span', { 'style': s }, '%h'.format(network.formatWifiEncryption(res.encryption))),
E('div', { 'class': 'right' }, E('button', {
'class': 'cbi-button cbi-button-action important',
'click': L.bind(this.handleJoin, this, radioDev, res)
'click': ui.createHandlerFn(this, 'handleJoin', radioDev, res)
}, _('Join Network')))
]);
@ -1886,7 +1886,7 @@ return view.extend({
};
s.handleJoin = function(radioDev, bss, ev) {
this.handleScanAbort(ev);
poll.remove(this.pollFn);
var m2 = new form.Map('wireless'),
s2 = m2.section(form.NamedSection, '_new_'),