Merge pull request #3359 from Andy2244/luci-app-cifsd_fix-defaults_19.07

luci-app-cifsd: fix defaults (none writeable default shares) [19.07]
This commit is contained in:
Jo-Philipp Wich 2019-11-25 16:00:13 +01:00 committed by GitHub
commit 819e67f6bf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -67,7 +67,8 @@ return L.view.extend({
o = s.option(form.Flag, 'read_only', _('Read-only'));
o.enabled = 'yes';
o.disabled = 'no';
o.default = 'no';
o.default = 'no'; // smb.conf default is 'yes'
o.rmempty = false;
s.option(form.Flag, 'force_root', _('Force Root'));
@ -77,24 +78,30 @@ return L.view.extend({
o = s.option(form.Flag, 'guest_ok', _('Allow guests'));
o.enabled = 'yes';
o.disabled = 'no';
o.default = 'yes';
o.default = 'yes'; // smb.conf default is 'no'
o.rmempty = false;
o = s.option(form.Flag, 'inherit_owner', _('Inherit owner'));
o.enabled = 'yes';
o.disabled = 'no';
o.default = 'no';
s.option(form.Flag, 'hide_dot_files', _('Hide dot files'));
o = s.option(form.Flag, 'hide_dot_files', _('Hide dot files'));
o.enabled = 'yes';
o.disabled = 'no';
o.default = 'yes';
o = s.option(form.Value, 'create_mask', _('Create mask'));
o.rmempty = true;
o.maxlength = 4;
o.default = '0666'; // smb.conf default is '0744'
o.placeholder = '0666';
o.rmempty = false;
o = s.option(form.Value, 'dir_mask', _('Directory mask'));
o.rmempty = true;
o.maxlength = 4;
o.default = '0777'; // smb.conf default is '0755'
o.placeholder = '0777';
o.rmempty = false;
return m.render();
}