Difuse/luci
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

application/luci-app-firewall: fix null access

Browse source 
Fixes: 48086e1c7b ("luci-app-firewall: Add ipset field to snats")
Fixes: d0d891c23e ("luci-app-firewall: Add ipset field to forwards (redirects)")
Fixes: f407a013ba ("luci-app-firewall: Add ipset field to rules")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
This commit is contained in:
Jo-Philipp Wich 2023-03-30 20:05:44 +02:00
parent 0c67d74fd3
commit 7a4afdcb05
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
applications/luci-app-firewall/htdocs/luci-static/resources/view/firewall/forwards.js
View file

@ -243,7 +243,7 @@ return view.extend({
o = s.taboption('advanced', form.Value, 'ipset', _('Use ipset'));
uci.sections('firewall', 'ipset', function(s) {
if (typeof(s.name) == 'string')
this.value(s.name, s.comment ? '%s (%s)'.format(s.name, s.comment) : s.name);
o.value(s.name, s.comment ? '%s (%s)'.format(s.name, s.comment) : s.name);
});
o.modalonly = true;
o.rmempty = true;

2
applications/luci-app-firewall/htdocs/luci-static/resources/view/firewall/rules.js
View file

@ -374,7 +374,7 @@ return view.extend({
o = s.taboption('advanced', form.Value, 'ipset', _('Use ipset'));
uci.sections('firewall', 'ipset', function(s) {
if (typeof(s.name) == 'string')
this.value(s.name, s.comment ? '%s (%s)'.format(s.name, s.comment) : s.name);
o.value(s.name, s.comment ? '%s (%s)'.format(s.name, s.comment) : s.name);
});
o.modalonly = true;
o.rmempty = true;

2
applications/luci-app-firewall/htdocs/luci-static/resources/view/firewall/snats.js
View file

@ -318,7 +318,7 @@ return view.extend({
o = s.taboption('advanced', form.Value, 'ipset', _('Use ipset'));
uci.sections('firewall', 'ipset', function(s) {
if (typeof(s.name) == 'string')
this.value(s.name, s.comment ? '%s (%s)'.format(s.name, s.comment) : s.name);
o.value(s.name, s.comment ? '%s (%s)'.format(s.name, s.comment) : s.name);
});
o.modalonly = true;
o.rmempty = true;