Difuse/luci
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

luci-app-mwan3: remove direct configuration possibility for /etc/config files

Browse source 
With this change it is not longer possible to edit the following
configuration files directly.

- mwan3
- wireless
- network

The user should edit the configuration over the provided luci pages.
which will do input checks and so prevent from miss configuration.

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
This commit is contained in:
Florian Eckert 2018-01-11 13:31:50 +01:00
parent 7b1725566c
commit 5aeeb69f15
7 changed files with 0 additions and 139 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
applications/luci-app-mwan3/luasrc/controller/mwan3.lua
View file

@ -56,16 +56,6 @@ function index()
entry({"admin", "network", "mwan", "configuration", "notify"},
cbi("mwan/notify"),
_("Notification"), 50).leaf = true
entry({"admin", "network", "mwan", "advanced"},
alias("admin", "network", "mwan", "advanced", "mwanconfig"),
_("Advanced"), 100)
entry({"admin", "network", "mwan", "advanced", "mwanconfig"},
form("mwan/advanced_mwanconfig"))
entry({"admin", "network", "mwan", "advanced", "networkconfig"},
form("mwan/advanced_networkconfig"))
entry({"admin", "network", "mwan", "advanced", "wirelessconfig"},
form("mwan/advanced_wirelessconfig"))
end
function getInterfaceStatus(ruleNumber, interfaceName)

32
applications/luci-app-mwan3/luasrc/model/cbi/mwan/advanced_mwanconfig.lua
View file

@ -1,32 +0,0 @@
-- ------ mwan configuration ------ --
ut = require "luci.util"
mwanConfig = "/etc/config/mwan3"
m5 = SimpleForm("luci", nil)
m5:append(Template("mwan/advanced_mwanconfig")) -- highlight current tab
f = m5:section(SimpleSection, nil,
translate("This section allows you to modify the contents of /etc/config/mwan3"))
t = f:option(TextValue, "lines")
t.rmempty = true
t.rows = 20
function t.cfgvalue()
return nixio.fs.readfile(mwanConfig) or ""
end
function t.write(self, section, data) -- format and write new data to script
return nixio.fs.writefile(mwanConfig, "\n" .. ut.trim(data:gsub("\r\n", "\n")) .. "\n")
end
function f.handle(self, state, data)
return true
end
return m5

32
applications/luci-app-mwan3/luasrc/model/cbi/mwan/advanced_networkconfig.lua
View file

@ -1,32 +0,0 @@
-- ------ network configuration ------ --
ut = require "luci.util"
networkConfig = "/etc/config/network"
m5 = SimpleForm("networkconf", nil)
m5:append(Template("mwan/advanced_networkconfig")) -- highlight current tab
f = m5:section(SimpleSection, nil,
translate("This section allows you to modify the contents of /etc/config/network"))
t = f:option(TextValue, "lines")
t.rmempty = true
t.rows = 20
function t.cfgvalue()
return nixio.fs.readfile(networkConfig) or ""
end
function t.write(self, section, data) -- format and write new data to script
return nixio.fs.writefile(networkConfig, "\n" .. ut.trim(data:gsub("\r\n", "\n")) .. "\n")
end
function f.handle(self, state, data)
return true
end
return m5

32
applications/luci-app-mwan3/luasrc/model/cbi/mwan/advanced_wirelessconfig.lua
View file

@ -1,32 +0,0 @@
-- ------ wireless configuration ------ --
ut = require "luci.util"
wirelessConfig = "/etc/config/wireless"
m5 = SimpleForm("wirelessconf", nil)
m5:append(Template("mwan/advanced_wirelessconfig")) -- highlight current tab
f = m5:section(SimpleSection, nil,
translate("This section allows you to modify the contents of /etc/config/wireless"))
t = f:option(TextValue, "lines")
t.rmempty = true
t.rows = 20
function t.cfgvalue()
return nixio.fs.readfile(wirelessConfig) or ""
end
function t.write(self, section, data) -- format and write new data to script
return nixio.fs.writefile(wirelessConfig, "\n" .. ut.trim(data:gsub("\r\n", "\n")) .. "\n")
end
function f.handle(self, state, data)
return true
end
return m5

11
applications/luci-app-mwan3/luasrc/view/mwan/advanced_mwanconfig.htm
View file

@ -1,11 +0,0 @@
<ul class="cbi-tabmenu">
<li class="cbi-tab"><a href="<%=luci.dispatcher.build_url("admin/network/mwan/advanced/mwanconfig")%>"><%:MWAN Config%></a></li>
<li class="cbi-tab-disabled"><a href="<%=luci.dispatcher.build_url("admin/network/mwan/advanced/networkconfig")%>"><%:Network Config%></a></li>
<li class="cbi-tab-disabled"><a href="<%=luci.dispatcher.build_url("admin/network/mwan/advanced/wirelessconfig")%>"><%:Wireless Config%></a></li>
</ul>
<style type="text/css">
.cbi-section {
padding: 20px;
}
</style>

11
applications/luci-app-mwan3/luasrc/view/mwan/advanced_networkconfig.htm
View file

@ -1,11 +0,0 @@
<ul class="cbi-tabmenu">
<li class="cbi-tab-disabled"><a href="<%=luci.dispatcher.build_url("admin/network/mwan/advanced/mwanconfig")%>"><%:MWAN Config%></a></li>
<li class="cbi-tab"><a href="<%=luci.dispatcher.build_url("admin/network/mwan/advanced/networkconfig")%>"><%:Network Config%></a></li>
<li class="cbi-tab-disabled"><a href="<%=luci.dispatcher.build_url("admin/network/mwan/advanced/wirelessconfig")%>"><%:Wireless Config%></a></li>
</ul>
<style type="text/css">
.cbi-section {
padding: 20px;
}
</style>

11
applications/luci-app-mwan3/luasrc/view/mwan/advanced_wirelessconfig.htm
View file

@ -1,11 +0,0 @@
<ul class="cbi-tabmenu">
<li class="cbi-tab-disabled"><a href="<%=luci.dispatcher.build_url("admin/network/mwan/advanced/mwanconfig")%>"><%:MWAN Config%></a></li>
<li class="cbi-tab-disabled"><a href="<%=luci.dispatcher.build_url("admin/network/mwan/advanced/networkconfig")%>"><%:Network Config%></a></li>
<li class="cbi-tab"><a href="<%=luci.dispatcher.build_url("admin/network/mwan/advanced/wirelessconfig")%>"><%:Wireless Config%></a></li>
</ul>
<style type="text/css">
.cbi-section {
padding: 20px;
}
</style>