Difuse/luci
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

luci-app-statistics: harden sysupgrade_backup

Browse source 
Remove sysupgrade_backup from help.  Also have it check parameters.

Signed-off-by: John Kohl <jtk.git@bostonpog.org>
This commit is contained in:
John Kohl 2023-11-11 11:19:58 -05:00 committed by Hannu Nyman
parent 465bfe24fa
commit 55e0f28b1e
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
applications/luci-app-statistics/root/etc/init.d/luci_statistics
View file

@ -13,9 +13,7 @@ SYSUPGRADE_BACKUP_TWIN_A="${BACKUP_DIR}/sysupgrade.trustme.txt"
SYSUPGRADE_BACKUP_TWIN_B="${BACKUP_DIR}/sysupgrade.dont.trustme.txt" SYSUPGRADE_BACKUP_TWIN_B="${BACKUP_DIR}/sysupgrade.dont.trustme.txt"
EXTRA_COMMANDS="backup sysupgrade_backup" EXTRA_COMMANDS="backup sysupgrade_backup"
EXTRA_HELP="\ EXTRA_HELP="\
backup Backup current rrd database if configured to do so\n\ backup Backup current rrd database if configured to do so"
sysupgrade_backup Take a special backup for sysupgrade/configuration saving"
TRACE=0 TRACE=0
doing_backups() { doing_backups() {
@ -150,6 +148,10 @@ copy_backup_for_sysupgrade() {
sysupgrade_backup() { sysupgrade_backup() {
local filelist="$1" local filelist="$1"
[ -z "$filelist" -o ! -f "$filelist" ] && {
echo sysupgrade_backup requires an existing filename argument 1>&2
exit 1
}
[ ${TRACE} -gt 0 ] && logger -t ${0##*/} -- luci_statistics sysupgrade_backup CONF_BACKUP_LIST=${CONF_BACKUP_LIST} [ ${TRACE} -gt 0 ] && logger -t ${0##*/} -- luci_statistics sysupgrade_backup CONF_BACKUP_LIST=${CONF_BACKUP_LIST}
doing_backups && { doing_backups && {
### CONF_BACKUP_LIST=1 means we are generating the ### CONF_BACKUP_LIST=1 means we are generating the