From 3e9d9a9dbb045c24eb93643838f8e8e3b9074e4b Mon Sep 17 00:00:00 2001
From: Viktor Tsvetkov <zwetvik@gmail.com>
Date: Fri, 24 Dec 2021 12:36:35 +0100
Subject: [PATCH] sysauth: add autocomplete and id attributes to login inputs

this let browser automatically fill according to HTML spec for input elements.
luci-theme-bootstrap and luci-base are affected.

Signed-off-by: Viktor Tsvetkov <zwetvik@gmail.com>
[indentation fix]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
---
 modules/luci-base/luasrc/view/sysauth.htm                 | 8 ++++----
 .../luasrc/view/themes/bootstrap/sysauth.htm              | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/modules/luci-base/luasrc/view/sysauth.htm b/modules/luci-base/luasrc/view/sysauth.htm
index acd5ff7e38..797c87a72e 100644
--- a/modules/luci-base/luasrc/view/sysauth.htm
+++ b/modules/luci-base/luasrc/view/sysauth.htm
@@ -20,15 +20,15 @@
 		</div>
 		<div class="cbi-section"><div class="cbi-section-node">
 			<div class="cbi-value">
-				<label class="cbi-value-title"><%:Username%></label>
+				<label class="cbi-value-title" for="luci_username"><%:Username%></label>
 				<div class="cbi-value-field">
-					<input class="cbi-input-text" type="text" name="luci_username" value="<%=duser%>" />
+					<input class="cbi-input-text" type="text" name="luci_username" id="luci_username" autocomplete="username" value="<%=duser%>" />
 				</div>
 			</div>
 			<div class="cbi-value cbi-value-last">
-				<label class="cbi-value-title"><%:Password%></label>
+				<label class="cbi-value-title" for="luci_password"><%:Password%></label>
 				<div class="cbi-value-field">
-					<input class="cbi-input-text" type="password" name="luci_password" />
+					<input class="cbi-input-text" type="password" name="luci_password" id="luci_password" autocomplete="current-password"/>
 				</div>
 			</div>
 		</div></div>
diff --git a/themes/luci-theme-bootstrap/luasrc/view/themes/bootstrap/sysauth.htm b/themes/luci-theme-bootstrap/luasrc/view/themes/bootstrap/sysauth.htm
index 8a97bbd104..72b04783bb 100644
--- a/themes/luci-theme-bootstrap/luasrc/view/themes/bootstrap/sysauth.htm
+++ b/themes/luci-theme-bootstrap/luasrc/view/themes/bootstrap/sysauth.htm
@@ -17,13 +17,13 @@
 				<div class="cbi-value">
 					<label class="cbi-value-title" for="luci_username"><%:Username%></label>
 					<div class="cbi-value-field">
-						<input name="luci_username" type="text"<%=attr("value", duser)%>>
+						<input name="luci_username" id="luci_username" type="text" autocomplete="username" <%=attr("value", duser)%>>
 					</div>
 				</div>
 				<div class="cbi-value">
 					<label class="cbi-value-title" for="luci_password"><%:Password%></label>
 					<div class="cbi-value-field">
-						<input name="luci_password" type="password">
+						<input name="luci_password" id="luci_password" type="password" autocomplete="current-password">
 					</div>
 				</div>
 			</div>