Difuse/luci
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

firewall: validate max length of zone name

Browse source 
fw3 sets the maximum length of the zone name to 14 and
ignores zone definitions with too long names.
http://nbd.name/gitweb.cgi?p=firewall3.git;a=blob;f=zones.h;hb=HEAD#l25
http://nbd.name/gitweb.cgi?p=firewall3.git;a=blob;f=zones.c;hb=HEAD#l195

Add a simple validation to ensure that the new zone name is short enough.
This should fix issue #345

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
This commit is contained in:
Hannu Nyman 2015-08-26 13:51:31 +03:00
parent 084d435060
commit 34e875b3d3
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
applications/luci-app-firewall/luasrc/model/cbi/firewall/zone-details.lua
View file

@ -76,6 +76,15 @@ function name.write(self, section, value)
} }
end end
function name.validate(self, value)
-- fw3 defines 14 as the maximum length of zone name
if #value > 14 then
return nil, translate("Zone name is too long")
else
return value
end
end
p = { p = {
s:taboption("general", ListValue, "input", translate("Input")), s:taboption("general", ListValue, "input", translate("Input")),
s:taboption("general", ListValue, "output", translate("Output")), s:taboption("general", ListValue, "output", translate("Output")),