Difuse/luci
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

luci-mod-system: sshkeys.js: prevent XSS through pubkey comments

Browse source 
Ensure to not display public key comments verbatim in order to prevent
injection of markup.

Reported-by: Eric McDonald <ericmcdonald@protonmail.com>
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 944b55738e)
This commit is contained in:
Jo-Philipp Wich 2022-09-21 14:47:41 +02:00
parent 63bfee6c8d
commit 30ba277989
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/luci-mod-system/htdocs/luci-static/resources/view/system/sshkeys.js
View file

@ -112,7 +112,7 @@ function renderKeyItem(pubkey) {
click: isReadonlyView ? null : removeKey,
'data-key': pubkey.src
}, [
E('strong', pubkey.comment || _('Unnamed key')), E('br'),
E('strong', [ pubkey.comment || _('Unnamed key') ]), E('br'),
E('small', [
'%s, %s'.format(pubkey.type, pubkey.curve || _('%d Bit').format(pubkey.bits)),
pubkey.options ? E([], [