Difuse/difuse-phone-android
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Add security for parsing integer value from settings

Browse source
This commit is contained in:
Sylvain Berfini 2012-11-21 12:01:05 +01:00
parent 4164f05740
commit cde3110e9d
1 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/org/linphone/LinphoneManager.java
View file

@ -673,6 +673,20 @@ public final class LinphoneManager implements LinphoneCoreListener {
} }
} }
private int tryToParseIntValue(String valueToParse, String defaultValue) {
return tryToParseIntValue(valueToParse, Integer.parseInt(defaultValue));
}
private int tryToParseIntValue(String valueToParse, int defaultValue) {
try {
int returned = Integer.parseInt(valueToParse);
return returned;
} catch (NumberFormatException nfe) {
}
return defaultValue;
}
public void initFromConf() throws LinphoneConfigException { public void initFromConf() throws LinphoneConfigException {
LinphoneCoreFactory.instance().setDebugMode(getPrefBoolean(R.string.pref_debug_key, false)); LinphoneCoreFactory.instance().setDebugMode(getPrefBoolean(R.string.pref_debug_key, false));
@ -688,7 +702,8 @@ public final class LinphoneManager implements LinphoneCoreListener {
readAndSetAudioAndVideoPorts(); readAndSetAudioAndVideoPorts();
int incomingCallTimeout = Integer.parseInt(getPrefString(R.string.pref_incoming_call_timeout_key, getString(R.string.pref_incoming_call_timeout_default))); String defaultIncomingCallTimeout = getString(R.string.pref_incoming_call_timeout_default);
int incomingCallTimeout = tryToParseIntValue(getPrefString(R.string.pref_incoming_call_timeout_key, defaultIncomingCallTimeout), defaultIncomingCallTimeout);
mLc.setIncomingTimeout(incomingCallTimeout); mLc.setIncomingTimeout(incomingCallTimeout);
try { try {