Fixed call recording on Android 10 + version bumped + updated gradle plugin + other crash fix

app/build.gradle

@@ -88,7 +88,7 @@ android {
     defaultConfig {
         minSdkVersion 21
         targetSdkVersion 29
-        versionCode 4212
+        versionCode 4213
         versionName "${project.version}"
         applicationId getPackageName()
         multiDexEnabled true

app/src/main/AndroidManifest.xml

@@ -64,7 +64,8 @@
         android:largeHeap="true"
         android:roundIcon="@mipmap/ic_launcher_round"
         android:resizeableActivity="true"
-        android:theme="@style/LinphoneStyle">
+        android:theme="@style/LinphoneStyle"
+        android:requestLegacyExternalStorage="true">
 
         <!-- Starting activities -->
 

app/src/main/java/org/linphone/assistant/PhoneAccountLinkingAssistantActivity.java

@@ -58,6 +58,7 @@ public class PhoneAccountLinkingAssistantActivity extends AssistantActivity {
             if (core == null) {
                 Log.e("[Account Linking Assistant] Core not available");
                 unexpectedError();
+                return;
             }
 
             ProxyConfig[] proxyConfigs = core.getProxyConfigList();
@@ -69,12 +70,14 @@ public class PhoneAccountLinkingAssistantActivity extends AssistantActivity {
                 if (identity == null) {
                     Log.e("[Account Linking Assistant] Proxy doesn't have an identity address");
                     unexpectedError();
+                    return;
                 }
                 if (!mProxyConfig.getDomain().equals(getString(R.string.default_domain))) {
                     Log.e(
                             "[Account Linking Assistant] Can't link account on domain "
                                     + mProxyConfig.getDomain());
                     unexpectedError();
+                    return;
                 }
                 accountCreator.setUsername(identity.getUsername());
 
@@ -82,6 +85,7 @@ public class PhoneAccountLinkingAssistantActivity extends AssistantActivity {
                 if (authInfo == null) {
                     Log.e("[Account Linking Assistant] Auth info not found");
                     unexpectedError();
+                    return;
                 }
                 accountCreator.setHa1(authInfo.getHa1());
                 accountCreator.setAlgorithm((authInfo.getAlgorithm()));
@@ -90,10 +94,12 @@ public class PhoneAccountLinkingAssistantActivity extends AssistantActivity {
                         "[Account Linking Assistant] Proxy config index out of bounds: "
                                 + proxyConfigIndex);
                 unexpectedError();
+                return;
             }
         } else {
             Log.e("[Account Linking Assistant] Proxy config index not found");
             unexpectedError();
+            return;
         }
 
         mCountryPicker = findViewById(R.id.select_country);

app/src/main/java/org/linphone/history/HistoryFragment.java

@@ -197,6 +197,7 @@ public class HistoryFragment extends Fragment
         if (mHistoryAdapter.isEditionEnabled()) {
             mHistoryAdapter.toggleSelection(position);
         } else {
+            if (position >= 0 && position < mLogs.size()) {
                 CallLog log = mLogs.get(position);
                 Address address;
                 if (log.getDir() == Call.Dir.Incoming) {
@@ -205,7 +206,9 @@ public class HistoryFragment extends Fragment
                     address = log.getToAddress();
                 }
                 if (address != null) {
-                LinphoneManager.getCallManager().newOutgoingCall(address.asStringUriOnly(), null);
+                    LinphoneManager.getCallManager()
+                            .newOutgoingCall(address.asStringUriOnly(), null);
+                }
             }
         }
     }

build.gradle

@@ -10,7 +10,7 @@ buildscript {
         }
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:3.5.2'
+        classpath 'com.android.tools.build:gradle:3.5.3'
         classpath 'com.google.gms:google-services:4.3.2'
         classpath "com.diffplug.spotless:spotless-plugin-gradle:3.24.2"