Difuse/difuse-phone-android
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Improved performances upon presence reception by reducing number of unecessary listener notification

Browse source
This commit is contained in:
Sylvain Berfini 2022-05-25 09:51:43 +02:00
parent 8485dea251
commit 90c7528540
3 changed files with 4 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
app/src/main/java/org/linphone/contact/ContactDataInterface.kt
View file

@ -50,20 +50,12 @@ open class GenericContactData(private val sipAddress: Address) : ContactDataInte
final override val displayName: MutableLiveData<String> = MutableLiveData<String>() final override val displayName: MutableLiveData<String> = MutableLiveData<String>()
final override val securityLevel: MutableLiveData<ChatRoomSecurityLevel> = MutableLiveData<ChatRoomSecurityLevel>() final override val securityLevel: MutableLiveData<ChatRoomSecurityLevel> = MutableLiveData<ChatRoomSecurityLevel>()
private val contactsUpdatedListener = object : ContactsUpdatedListenerStub() {
override fun onContactUpdated(friend: Friend) {
contactLookup()
}
}
init { init {
securityLevel.value = ChatRoomSecurityLevel.ClearText securityLevel.value = ChatRoomSecurityLevel.ClearText
coreContext.contactsManager.addListener(contactsUpdatedListener)
contactLookup() contactLookup()
} }
open fun destroy() { open fun destroy() {
coreContext.contactsManager.removeListener(contactsUpdatedListener)
} }
private fun contactLookup() { private fun contactLookup() {
@ -79,24 +71,11 @@ abstract class GenericContactViewModel(private val sipAddress: Address) : Messag
final override val displayName: MutableLiveData<String> = MutableLiveData<String>() final override val displayName: MutableLiveData<String> = MutableLiveData<String>()
final override val securityLevel: MutableLiveData<ChatRoomSecurityLevel> = MutableLiveData<ChatRoomSecurityLevel>() final override val securityLevel: MutableLiveData<ChatRoomSecurityLevel> = MutableLiveData<ChatRoomSecurityLevel>()
private val contactsUpdatedListener = object : ContactsUpdatedListenerStub() {
override fun onContactUpdated(friend: Friend) {
contactLookup()
}
}
init { init {
securityLevel.value = ChatRoomSecurityLevel.ClearText securityLevel.value = ChatRoomSecurityLevel.ClearText
coreContext.contactsManager.addListener(contactsUpdatedListener)
contactLookup() contactLookup()
} }
override fun onCleared() {
coreContext.contactsManager.removeListener(contactsUpdatedListener)
super.onCleared()
}
private fun contactLookup() { private fun contactLookup() {
displayName.value = LinphoneUtils.getDisplayName(sipAddress) displayName.value = LinphoneUtils.getDisplayName(sipAddress)
contact.value = coreContext.contactsManager.findContactByAddress(sipAddress) contact.value = coreContext.contactsManager.findContactByAddress(sipAddress)

4
app/src/main/java/org/linphone/contact/ContactLoader.kt
View file

@ -41,6 +41,7 @@ import org.linphone.R
import org.linphone.core.Factory import org.linphone.core.Factory
import org.linphone.core.Friend import org.linphone.core.Friend
import org.linphone.core.GlobalState import org.linphone.core.GlobalState
import org.linphone.core.SubscribePolicy
import org.linphone.core.tools.Log import org.linphone.core.tools.Log
import org.linphone.utils.LinphoneUtils import org.linphone.utils.LinphoneUtils
import org.linphone.utils.PhoneNumberUtils import org.linphone.utils.PhoneNumberUtils
@ -136,7 +137,10 @@ class ContactLoader : LoaderManager.LoaderCallbacks<Cursor> {
friend.starred = starred friend.starred = starred
friend.nativeUri = friend.nativeUri =
"${ContactsContract.Contacts.CONTENT_LOOKUP_URI}/$lookupKey" "${ContactsContract.Contacts.CONTENT_LOOKUP_URI}/$lookupKey"
// Disable short term presence
friend.isSubscribesEnabled = false friend.isSubscribesEnabled = false
friend.incSubscribePolicy = SubscribePolicy.SPDeny
} }
when (mime) { when (mime) {

1
app/src/main/java/org/linphone/contact/ContactsManager.kt
View file

@ -283,7 +283,6 @@ class ContactsManager(private val context: Context) {
val id = friend.refKey val id = friend.refKey
if (id != null) { if (id != null) {
storePresenceInNativeContact(friend) storePresenceInNativeContact(friend)
notifyListeners(friend)
} }
} }
} }